[blink-dev] Re: Question about "component_deps_blink Assignment had no effect" build error on ios.

2024-05-21 Thread 'Colin Blundell' via blink-dev
I missed this in the CL review, sorry - you have a dependency on Blink in the component but iOS doesn't use Blink in its default build configuration. Try building the iOS files only if `use_blink` is true and also gating the addition of the unittest target as a components_unittests dep on `use_blin

Re: [blink-dev] Where are the expectations impacting the canvas_webgpu_transfer layout tests?

2024-09-11 Thread 'Colin Blundell' via blink-dev
On Wed, Sep 11, 2024 at 5:58 PM Fredrik Söderquist wrote: > On Wed, Sep 11, 2024 at 5:16 PM Colin Blundell > wrote: > >> >> >> On Wed, Sep 11, 2024 at 5:06 PM Fredrik Söderquist wrote: >> >>> On Wed, Sep 11, 2024 at 4:43 PM Colin Blundell >>> wrote: >>> On Wed, Sep 11, 2024 at 4