Re: [blink-dev] Re: Intent to Ship: WebGPU: GPUAdapter info attribute

2024-05-31 Thread Yoav Weiss (@Shopify)
LGTM2 On Fri, May 31, 2024 at 7:35 AM Domenic Denicola wrote: > In that case, LGTM1. > > On Fri, May 31, 2024 at 2:31 PM François Beaufort > wrote: > >> >> >> On Fri, May 31, 2024 at 3:16 AM Domenic Denicola >> wrote: >> >>> >>> >>> On Thursday, May 30, 2024 at 1:34:03 PM UTC+9 fbea...@google.

Re: [blink-dev] Intent to Ship: Support Video Chapter in MediaMetadata

2024-05-31 Thread Yoav Weiss (@Shopify)
LGTM2 On Fri, May 31, 2024 at 5:52 AM 'Jiaming Cheng' via blink-dev < blink-dev@chromium.org> wrote: > Thanks Domenic :] > > On Thu, May 30, 2024 at 6:28 PM Domenic Denicola > wrote: > >> LGTM1. >> >> This feature and its spec fits well with the existing MediaMetadata. It >> has received a posit

[blink-dev] Intent to Implement and Ship: Line-breakable ruby

2024-05-31 Thread TAMURA, Kent
Contact emailstk...@chromium.org Explainer https://docs.google.com/document/d/1hzvrwoE_0aw08X_CaU40zV5bXbMQjY2SHQHj3Np4sDo/edit?pli=1#heading=h.acpilydj9j1d Specificationhttps://drafts.csswg.org/css-ruby/#break-within Design docs https://docs.google.com/document/d/1hzvrwoE_0aw08X_CaU40zV5bXbMQjY

Re: [blink-dev] Intent-to-Ship: MediaRecorder keyframe configurability

2024-05-31 Thread 'Markus Handell' via blink-dev
Hi Peter, from the spec text: "If videoKeyFrameIntervalCount is not null ... the video encoder produces a keyframe on the *first* frame arriving *after* *videoKeyFrameIntervalCount frames passed* *since* the last key frame" It sounds to me like the blink impl is correctly implementing the spec me

Re: [blink-dev] Intent to Extend Experiment: Compression Dictionary Transport

2024-05-31 Thread Mike Taylor
Thanks Domenic - I agree. On 5/30/24 9:31 PM, Domenic Denicola wrote: LGTM for a new OT from 127 to 129. (Speaking generally, I think starting new OTs is better than extending existing ones, so I am glad the team has taken this route. From an ecosystem perspective, new OTs make it easier for

Re: [blink-dev] Re: Intent to Ship: WebGPU: GPUAdapter info attribute

2024-05-31 Thread Mike Taylor
LGTM3 On 5/31/24 4:07 AM, Yoav Weiss (@Shopify) wrote: LGTM2 On Fri, May 31, 2024 at 7:35 AM Domenic Denicola wrote: In that case, LGTM1. On Fri, May 31, 2024 at 2:31 PM François Beaufort wrote: On Fri, May 31, 2024 at 3:16 AM Domenic Denicola wrote:

Re: [blink-dev] Intent-to-Ship: MediaRecorder keyframe configurability

2024-05-31 Thread Peter Kasting
On Fri, May 31, 2024, 5:43 AM Markus Handell wrote: > Hi Peter, from the spec text: > > "If videoKeyFrameIntervalCount is not null ... the video encoder produces > a keyframe on the *first* frame arriving *after* *videoKeyFrameIntervalCount > frames passed* *since* the last key frame" > > It soun

Re: [blink-dev] Intent to Ship: Support Video Chapter in MediaMetadata

2024-05-31 Thread Mike Taylor
LGTM3 On 5/31/24 4:08 AM, Yoav Weiss (@Shopify) wrote: LGTM2 On Fri, May 31, 2024 at 5:52 AM 'Jiaming Cheng' via blink-dev wrote: Thanks Domenic :] On Thu, May 30, 2024 at 6:28 PM Domenic Denicola wrote: LGTM1. This feature and its spec fits well with the exi

Re: [blink-dev] Intent-to-Ship: MediaRecorder keyframe configurability

2024-05-31 Thread 'Markus Handell' via blink-dev
It was a while, but the discussions we had were not revolving around this corner case. I think it makes sense for the implementation to keep adhering to the "exclusive of" to get rid of the ambiguity of what 0 means in Interval. I also don't see another way to interpret the spec text. For the durat

[blink-dev] Intent to Ship: Protected Audience: Allow trusted bidding signals to trigger interest group updates

2024-05-31 Thread Paul Jensen
Contact emails pauljen...@chromium.org Explainer https://github.com/WICG/turtledove/pull/1095 Specification https://github.com/WICG/turtledove/pull/1124 Summary The Protected Audience API allows bidders to store information, called an interest group, from a single site in the browser that

Re: [blink-dev] Intent-to-Ship: MediaRecorder keyframe configurability

2024-05-31 Thread Peter Kasting
0 is actually the one unambiguous case -- it clearly means you want a key frame every frame. Seems strange that someone whose steam has a key frame every 30 frames should specify a count of 29. I dunno though, if that's also what other vendors do then changing is far more trouble than benefit. Do

Re: [blink-dev] Intent to Extend Experiment: Compression Dictionary Transport

2024-05-31 Thread 'Jason Robbins' via blink-dev
Tsuyoshi, Previously your third OT stage on ChromeStatus got associated with your second trial on OT Console. That is probably due to a bug in ChromeStatus. We'll look into that. To let you continue with requesting this new trial, I have cleared out the trial ID for that third OT stage on Chr

Re: [blink-dev] Intent to Ship: Dispatch selectionchange event per element

2024-05-31 Thread Chris Harrelson
LGTM3 for the first CL On Thu, May 30, 2024 at 6:22 PM Domenic Denicola wrote: > LGTM2, to land the first CL. > > Thanks for explaining. It sounds like the first CL, which this Intent is > covering, is purely additive and should not have significant compatibility > risk. It also brings us in lin

[blink-dev] Intent to Extend Deprecation Trial: Restrict "private network requests" for subresources from public websites to secure contexts.

2024-05-31 Thread Emily Stark
Contact emailsest...@google.com, jdebla...@google.com, dadr...@google.com, l...@chromium.org, tito...@chromium.org, cl...@chromium.org, mk...@chromium.org, v...@chromium.org Explainer https://github.com/WICG/private-network-access/blob/master/explainer.md Specificationhttps://wicg.github.io/priva

[blink-dev] Intent to Extend Experiment: Tabbed web apps

2024-05-31 Thread Brett Wilson
Hi Blink owners, We would like to apply to extend the Tabbed web apps origin trial until November 26th, 2024. This API is already approved to ship in 126 (Intent to Ship thread