Re: [blink-dev] Re: Intent to Ship: NavigateEvent sourceElement

2025-02-14 Thread Philip Jägenstedt
Correction, https://github.com/whatwg/html/pull/10898 was the spec PR. But everything still looks to be in good order. On Thu, Feb 13, 2025 at 9:02 PM Mike Taylor wrote: > LGTM3 > On 2/13/25 11:27 AM, Chris Harrelson wrote: > > LGTM2 > > On Thu, Feb 13, 2025 at 2:47 AM Philip Jägenstedt > wrote

Re: [blink-dev] Re: Intent to Ship: NavigateEvent sourceElement

2025-02-13 Thread Mike Taylor
LGTM3 On 2/13/25 11:27 AM, Chris Harrelson wrote: LGTM2 On Thu, Feb 13, 2025 at 2:47 AM Philip Jägenstedt wrote: LGTM1, a small but useful addition to the platform. The spec change was done in https://github.com/whatwg/html/pull/10971 and everything looks to be in good orde

Re: [blink-dev] Re: Intent to Ship: NavigateEvent sourceElement

2025-02-13 Thread Chris Harrelson
LGTM2 On Thu, Feb 13, 2025 at 2:47 AM Philip Jägenstedt wrote: > LGTM1, a small but useful addition to the platform. > > The spec change was done in https://github.com/whatwg/html/pull/10971 and > everything looks to be in good order. > > On Thu, Feb 13, 2025 at 5:35 AM Domenic Denicola > wrote

Re: [blink-dev] Re: Intent to Ship: NavigateEvent sourceElement

2025-02-13 Thread Philip Jägenstedt
LGTM1, a small but useful addition to the platform. The spec change was done in https://github.com/whatwg/html/pull/10971 and everything looks to be in good order. On Thu, Feb 13, 2025 at 5:35 AM Domenic Denicola wrote: > I'm recusing myself from this Intent, but one small comment about TAG > r