Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

Was a bit confused cause the deprecations are printed to console as errors and not as warnings. So I thouht we have to handle that fast in our software and I was not sure when the removal will be done. Is the output as an error the correct way to go? Cause until the milestone is not reached, I c

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

The new syntax is shipping in the milestone on the chromestatus, and at that time both syntaxes will work at the same time. To fix the deprecation message, just migrate to the new syntax. I will put down a milestone for the removal when I have everything ready including an enterprise policy to re-

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

> The plan looks good, but I think chromestatus.com can't handle the removal of the old syntax and the addition of the new syntax in a single entry. > Joey, can you create a new entry for shipping the new syntax? Sure: https://chromestatus.com/feature/5586433790443520 Should I start another intent

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

The plan looks good, but I think chromestatus.com can't handle the removal of the old syntax and the addition of the new syntax in a single entry. Joey, can you create a new entry for shipping the new syntax? On Wed, Dec 27, 2023 at 3:54 AM Chris Harrelson wrote: > LGTM1 to ship. > > On Tue, Dec

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

LGTM1 to ship. On Tue, Dec 26, 2023, 10:10 AM Joey Arhar wrote: > Thanks Luke! > Now that WebKit is shipping, can I get approval to implement and ship > :state(foo) alongside :--foo, then deprecate and remove :--foo? > > On Sat, Dec 23, 2023 at 12:17 PM Luke wrote: > >> Fwiw CustomStateSets wit

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

Thanks Luke! Now that WebKit is shipping, can I get approval to implement and ship :state(foo) alongside :--foo, then deprecate and remove :--foo? On Sat, Dec 23, 2023 at 12:17 PM Luke wrote: > Fwiw CustomStateSets with the :state() syntax is now enabled by default on > WebKit trunk. > https://g

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

Fwiw CustomStateSets with the :state() syntax is now enabled by default on WebKit trunk. https://github.com/WebKit/WebKit/compare/8faf2e8d8d0c...26f4507be15d On Tuesday 24 October 2023 at 01:47:10 UTC+1 sligh...@chromium.org wrote: > For the avoidance of doubt, would just like to re-emphasise t

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

For the avoidance of doubt, would just like to re-emphasise that landing a new syntax is less attractive than compatible additions to the existing one. If there are new problems being solved by the new syntax, it might be helpful to explain what they are in a short summary somewhere, with bonus poi

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

On Sun, Oct 22, 2023 at 9:32 PM Domenic Denicola wrote: > > > On Sat, Oct 21, 2023 at 1:10 AM Chris Harrelson > wrote: > >> >> >> On Fri, Oct 20, 2023 at 9:00 AM Joey Arhar wrote: >> >>> > > For the purposes of WHATWG's multi-implementer support criteria: I >>> will assume we cannot check the b

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

On Sat, Oct 21, 2023 at 1:10 AM Chris Harrelson wrote: > > > On Fri, Oct 20, 2023 at 9:00 AM Joey Arhar wrote: > >> > > For the purposes of WHATWG's multi-implementer support criteria: I >> will assume we cannot check the box for "Chromium supports this feature" >> until a different browser has

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

On Fri, Oct 20, 2023 at 9:00 AM Joey Arhar wrote: > > > For the purposes of WHATWG's multi-implementer support criteria: I > will assume we cannot check the box for "Chromium supports this feature" > until a different browser has shipped :state() to their stable channel. > (Let me know if that is

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

> > For the purposes of WHATWG's multi-implementer support criteria: I will assume we cannot check the box for "Chromium supports this feature" until a different browser has shipped :state() to their stable channel. (Let me know if that is incorrect.) > > Chromium does support the feature, and it s

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

On Thu, Oct 19, 2023 at 6:48 PM Domenic Denicola wrote: > Thanks Chris and the API Owners for having this discussion! I am > sympathetic to this being a hard problem with the strong potential to set a > bad precedent. > > On Fri, Oct 20, 2023 at 3:00 AM Chris Harrelson > wrote: > >> >> >> On Thu

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

Thanks Chris and the API Owners for having this discussion! I am sympathetic to this being a hard problem with the strong potential to set a bad precedent. On Fri, Oct 20, 2023 at 3:00 AM Chris Harrelson wrote: > > > On Thu, Oct 19, 2023 at 10:59 AM Chris Harrelson > wrote: > >> The API owners

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

On Thu, Oct 19, 2023 at 10:59 AM Chris Harrelson wrote: > The API owners met yesterday and discussed this intent. Our consensus was > that we would like to wait until another browser has implemented and is > shipping :state before we approve shipping it in Chromium. We also don't > recommend spen

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

The API owners met yesterday and discussed this intent. Our consensus was that we would like to wait until another browser has implemented and is shipping :state before we approve shipping it in Chromium. We also don't recommend spending more time on further bikeshet spec discussions for it in the

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

Hey all, We've spent a LOT of time discussing this one in API OWNERS, and my disinclination to allow this to move forward remains. What we're observing in this Intent is an anti-pattern in which: - Chromium engineers follow a process that is designed to put developer needs above implemen

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

I don't normally weigh in on these but I just wanted to say that I think this one is pretty unique for a whole bunch of reasons and it's not just an example of bikeshedding after shipping by a specific vendor or something. It's more than that. As much as I think this is important, and wanted i

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

Regarding why change to :state() instead of :--: as is typical, it was done in order to gain consensus; in particular, the CSSWG resolution notes indicate (see comment from the chair) one motivation is to align with WHATWG an

Re: [blink-dev] Re: Intent to Ship: Deprecate old CSS custom state syntax

On Wed, Oct 4, 2023 at 2:24 PM Jeffrey Yasskin wrote: > Apparently +Chris Wilson had part of this discussion > with Alan Stearns in April at > https://github.com/w3c/csswg-drafts/issues/8730#issuecomment-1524167658, > and the suggestion was that if a CSS spec for a feature is "unstable" > (meani