Re: [blink-dev] Intent to Ship: CSS advanced attr() function

2024-12-11 Thread Rick Byers
3 potential sites in the 12 M for something almost certainly minor/superficial UI breakage indeed seems exceedingly low risk to me. LGTM3 to ship. But as always, if you get reports of breakage prior to hitting stable, please use the kill-switch and circle back here for a more thorough compat analy

Re: [blink-dev] Intent to Ship: CSS advanced attr() function

2024-12-11 Thread Mike Taylor
+1 to Vladimir's recommendation here. LGTM2 On 12/11/24 4:00 PM, Vladimir Levin wrote: Thanks for the analysis. I think the compat risk here is low. Since we know of at least 3 instances that are likely to break, or at least to have a different behavior, I'd ask that we try to reach out to th

Re: [blink-dev] Intent to Ship: CSS advanced attr() function

2024-12-11 Thread Vladimir Levin
Thanks for the analysis. I think the compat risk here is low. Since we know of at least 3 instances that are likely to break, or at least to have a different behavior, I'd ask that we try to reach out to those sites as an FYI about this change. Other than that, LGTM1 On Wed, Dec 11, 2024 at 12

Re: [blink-dev] Intent to Ship: CSS advanced attr() function

2024-12-11 Thread 'Munira Tursunova' via blink-dev
Thank you for your replies. I notice that we're failing all the tests on > https://wpt.fyi/results/css/css-values?label=master&label=experimental&aligned&q=attr > , > probably because this feature is not available behind the > experimental-web-platform-features flag. > > Can you confirm that we'r

Re: [blink-dev] Intent to Ship: CSS advanced attr() function

2024-12-04 Thread Rick Byers
Discussed in API owners meeting today that we don't really understand the compat risk here. Vlad makes a compelling argument that the risk in example #2 may be non-trivial (especially when considering inheritance scenarios beyond just custom properties). Also you'll need to request enterprise revie

Re: [blink-dev] Intent to Ship: CSS advanced attr() function

2024-12-04 Thread Daniel Bratell
Beyond what Vlad and Dominic has mentioned, we're also missing formal signals from other vendors. They have requested that we not use generic opinions from staff as official signals. You can find how to get formals vendor signals by following the link "signals on their opinion of the API" in ht

Re: [blink-dev] Intent to Ship: CSS advanced attr() function

2024-12-03 Thread Vladimir Levin
On Mon, Dec 2, 2024 at 10:47 PM Domenic Denicola wrote: > Thank you, that explainer is very helpful! > > I notice that we're failing all the tests on > https://wpt.fyi/results/css/css-values?label=master&label=experimental&aligned&q=attr > , probably because this feature is not available behind t

Re: [blink-dev] Intent to Ship: CSS advanced attr() function

2024-12-02 Thread Domenic Denicola
Thank you, that explainer is very helpful! I notice that we're failing all the tests on https://wpt.fyi/results/css/css-values?label=master&label=experimental&aligned&q=attr , probably because this feature is not available behind the experimental-web-platform-features flag. Can you confirm that w

Re: [blink-dev] Intent to Ship: CSS advanced attr() function

2024-12-02 Thread 'Munira Tursunova' via blink-dev
Thank you, Domenic! I uploaded explainer here: https://github.com/tursunova/web-platform-explainer/blob/main/advanced-attr-explainer.md . On Wed, Nov 27, 2024 at 3:02 AM Domenic Denicola wrote: > > > On Tue, Nov 26, 2024 at 8:07 PM Chromestatus < > ad...@cr-status.appspotmail.com> wrote: > >> C

Re: [blink-dev] Intent to Ship: CSS advanced attr() function

2024-11-26 Thread Domenic Denicola
On Tue, Nov 26, 2024 at 8:07 PM Chromestatus < ad...@cr-status.appspotmail.com> wrote: > Contact emails moon...@google.com, chris...@chromium.org > > Explainer None Some sort of explainer would be appreciated for this change, especially given the security complexity. > > > Specification https: