Hi,
After coordinating with my colleague Roger Zanoni, I will continue the
development and shipping of this feature.
In the previous discussion, two years ago, one of the concerns was that the
lack of sufficient WPT tests.
Fortunately, at the moment there are 25 WPT tests for the :lang selecto
On 4/8/23 05:15, Jonathan Kew wrote:
Looking at the webkit tests, I"m concerned that some of them may conflict with
the spec (as I understand it), and this presumably reflects an issue with
webkit's implementation.
[...]
and BCP47 specifically mentions that
the language tags described in this
Looking at the webkit tests, I"m concerned that some of them may conflict
with the spec (as I understand it), and this presumably reflects an issue
with webkit's implementation.
Specifically, in
https://github.com/WebKit/WebKit/blob/main/LayoutTests/fast/selectors/lang-extended-filtering.html
Make that LGTM3, after Philip's LGTM2
/Daniel
On 2023-04-05 17:42, Daniel Bratell wrote:
LGTM2
/Daniel
On 2023-04-05 05:58, Yoav Weiss wrote:
LGTM1 once this is WPT tested with good coverage and our shipped
behavior matches both WebKit and the spec. Please get back to this
thread if e.g. t
LGTM2
/Daniel
On 2023-04-05 05:58, Yoav Weiss wrote:
LGTM1 once this is WPT tested with good coverage and our shipped
behavior matches both WebKit and the spec. Please get back to this
thread if e.g. the implemented WebKit behavior varies from the
specified one.
On Thu, Mar 30, 2023 at 9:09
LGTM2, and thanks for taking another look over the tests and ensuring solid
coverage in WPT!
On Wed, Apr 5, 2023 at 5:58 AM Yoav Weiss wrote:
> LGTM1 once this is WPT tested with good coverage and our shipped behavior
> matches both WebKit and the spec. Please get back to this thread if e.g.
> t
LGTM1 once this is WPT tested with good coverage and our shipped behavior
matches both WebKit and the spec. Please get back to this thread if e.g.
the implemented WebKit behavior varies from the specified one.
On Thu, Mar 30, 2023 at 9:09 AM Roger Zanoni wrote:
> Hi Philip, thanks for looking f
Hi Philip, thanks for looking for the tests, they are relevant but they
don't cover some cases, like implicit wildcard matching with more than one
language subtags, private singleton matching
I think we should add more cases to wpt tests targeting specific level4
matching logic, like the cases
Hi Yoav, thanks for checking, I will answer inline
On Friday, March 17, 2023 at 10:59:14 AM UTC+1 yoav...@chromium.org wrote:
On Thu, Mar 16, 2023 at 11:09 AM Roger Zanoni wrote:
Contact emails rza...@igalia.com
Explainer https://github.com/rogerzanoni/docs/tree/main/lang-level-4
Specificati
Hi Roger,
I took a look for the tests, and am wondering if the tests added here are
for Level 4?
https://github.com/web-platform-tests/wpt/pull/37950
At least some of them are already passing in Chrome Dev (with experimental
features enabled), but not Chrome stable, so some of these tests seem
re
On Thu, Mar 16, 2023 at 11:09 AM Roger Zanoni wrote:
> Contact emails rzan...@igalia.com
>
> Explainer https://github.com/rogerzanoni/docs/tree/main/lang-level-4
>
> Specification https://www.w3.org/TR/selectors-4/#the-lang-pseudo
>
> Summary
>
> The :lang CSS pseudo-class currently matches eleme
16 Mar 2023 Per, saat 13:09 tarihinde Roger Zanoni
şunu yazdı:
> Contact emails rzan...@igalia.com
>
> Explainer https://github.com/rogerzanoni/docs/tree/main/lang-level-4
>
> Specification https://www.w3.org/TR/selectors-4/#the-lang-pseudo
>
> Summary
>
> The :lang CSS pseudo-class currently mat
12 matches
Mail list logo