Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-06-28 Thread Mike Wasserman
Permissions API query support is now reflected in the explainer [1] and the prototype [2] will be enabled by default in M128 [3]. Thanks for all the reviews and input, please do share any additional feedback. [1] https://github.com/explainers-by-googlers/html-fullscreen-without-a-gesture#permissio

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-17 Thread Philip Jägenstedt
Hi Mike, I think the use cases here are clear and skipping the user activation requirement is the only way to meet them. I believe that the biggest risk here is content written assuming this setting not working without it, and it being hard to understand why. In other words, debuggability and feat

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-16 Thread Vladimir Levin
LGTM2 On Thu, May 16, 2024 at 11:16 AM Mike Taylor wrote: > LGTM1, with the commitment to follow up on Permissions API integration > (thanks!). > On 5/15/24 6:34 PM, Reilly Grant wrote: > > LGTM as an IWA OWNER (3x LGTM from Blink API OWNERS are still required > according to the IWA-specific API

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-16 Thread Mike Taylor
LGTM1, with the commitment to follow up on Permissions API integration (thanks!). On 5/15/24 6:34 PM, Reilly Grant wrote: LGTM as an IWA OWNER (3x LGTM from Blink API OWNERS are still required according to the IWA-specific API launch process

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-15 Thread Reilly Grant
LGTM as an IWA OWNER (3x LGTM from Blink API OWNERS are still required according to the IWA-specific API launch process ). Thank you for working with the IWA and Security reviewers to figure out the right restrictions to prevent

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-15 Thread Mike Wasserman
Our team can commit to adding Permissions API query integration, with the requisite approvals. That would provide feature detection, and also clarify requestFullscreen method steps in the spec. I'm requesting approval to ship the feature in its current state, given our commitment to follow up. Th

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-15 Thread Mike Wasserman
No, this content setting does not have Permissions API integration at this time. That seems like a great future improvement, especially if user control of the setting is extended to more contexts. On Wed, May 15, 2024 at 9:37 AM Alex Russell wrote: > Will the status of the permission be reflecte

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-15 Thread Alex Russell
Will the status of the permission be reflected in the Permissions API? I see Permissions Policy integration, but not the Permissions API reflection that I'd expect. Best, Alex On Tuesday, May 14, 2024 at 3:54:24 PM UTC-7 Mike Wasserman wrote: > Thanks! I pinged the PR, and hope for some feedb

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-14 Thread Mike Wasserman
Thanks! I pinged the PR, and hope for some feedback there soon. Feature detection via Permissions API querying seems like a great follow up here, ideally alongside broadened feature availability (i.e. extending user control beyond Isolated Web Apps). On Tue, May 14, 2024 at 1:43 PM Mike Taylor

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-14 Thread Mike Taylor
It would be nice for the PR to be reviewed and approved, even without other stakeholder support. Additionally - the explainer mentions a few options for feature detection. Any progress on that front? Or is it just hypothetical? On 5/9/24 3:04 PM, Mike Wasserman wrote: Sure. I'll note that wha

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-09 Thread Mike Wasserman
Sure. I'll note that whatwg/fullscreen's PR merging includes a question or criteria "At least two implementers are interested (and none opposed)". I have filed standards position requests with Mozilla and WebKit, and I will ping fullscreen spec maintainers for input. On Thu, May 9, 2024 at 11:39 A

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-09 Thread Vladimir Levin
Ah thanks, I missed it in the explainer. The spec changes make sense to me. The changes don't look like they would be controversial, but it's probably worthwhile to ensure that this PR is under review and/or landing as a part of shipping this. Thanks! Vlad On Thu, May 9, 2024 at 12:20 PM Mike Was

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-09 Thread Mike Wasserman
Yes, there's a draft PR with the Explainer's anticipated spec changes , which are designed

Re: [blink-dev] Intent to Ship: Automatic Fullscreen Content Setting

2024-05-09 Thread Vladimir Levin
On Wed, May 8, 2024 at 7:46 PM Mike Wasserman wrote: > Contact emails > > m...@chromium.org, fugu-...@chromium.org > > Explainer > > https://github.com/explainers-by-googlers/html-fullscreen-without-a-gesture > > Specification > > https://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen