Re: [blink-dev] Re: Intent to Ship: Expose ReadableStreamDefaultController interface

2022-07-14 Thread 'Joe Medley' via blink-dev
Apparently, I missed this so I do intend to add it to the beta post. let TransformStreamDefaultController; new TransformStream({ start(c) { TransformStreamDefaultController = c.constructor; } }); Joe Medley | Technical Writer, Chrome DevRel | jmed...@google.com | 816-678-7195 *If an API's not doc

Re: [blink-dev] Re: Intent to Ship: Expose ReadableStreamDefaultController interface

2022-07-14 Thread 'Joe Medley' via blink-dev
Domenic, Thank you for the information. I dug into this before deciding whether to include it in the blog post. >From what I gather in the spec, the only way to get an instance of this is through a number of callbacks (TransformerStartCallback, TransformerFlushCallback, and TransformerTransformCa

Re: [blink-dev] Re: Intent to Ship: Expose ReadableStreamDefaultController interface

2022-07-13 Thread Domenic Denicola
Thanks Alex! I'll work on the Intent now. A response to Joe's question below. On Thu, Jul 14, 2022 at 1:10 AM Joe Medley wrote: > Gang, > > I want to make sure I understand. It seems like this is just a bug fix or > something like it. I want to understand before I agree that it doesn't need > a

Re: [blink-dev] Re: Intent to Ship: Expose ReadableStreamDefaultController interface

2022-07-13 Thread 'Joe Medley' via blink-dev
Gang, I want to make sure I understand. It seems like this is just a bug fix or something like it. I want to understand before I agree that it doesn't need a mention in the blog post. Here's what I think it sounds like. The functionality shipped in Chrome 89 as shown on the status entry, but it d

Re: [blink-dev] Re: Intent to Ship: Expose ReadableStreamDefaultController interface

2022-07-13 Thread Alex Russell
Hey Domenic, Discussed at today's API OWNERS and we decided that: - It makes sense for this to be an intent - We're happy to see this skipped for TAG review as it is covered by previous reviews - You should expect the intent to be fast-tracked once filed, and please just link to

Re: [blink-dev] Re: Intent to Ship: Expose ReadableStreamDefaultController interface

2022-07-11 Thread Domenic Denicola
While I'm happy to do it, I think I may not have explained the situation well enough, so let me ask a clarifying question... On Tue, Jul 12, 2022 at 3:00 PM Yoav Weiss wrote: > Hey Domenic! > > While I agree it's a very similar case, it's not identical. > I agree that a TAG review is not needed

Re: [blink-dev] Re: Intent to Ship: Expose ReadableStreamDefaultController interface

2022-07-11 Thread Yoav Weiss
Hey Domenic! While I agree it's a very similar case, it's not identical. I agree that a TAG review is not needed here, nor getting positions from other vendors, but there's still some risk in exposing the interface where it wasn't exposed before. (e.g. sites using the lack of exposure for some wei

Re: [blink-dev] Re: Intent to Ship: Expose ReadableStreamDefaultController interface

2022-07-11 Thread TAMURA, Kent
IMO, it's a bug fix and we don't need a dedicated I2S. On Tue, Jul 12, 2022 at 11:37 AM Domenic Denicola wrote: > Hey all, > > Today I was browsing > https://wpt.fyi/results/streams?label=experimental&label=master&aligned > and noticed that we were failing tests because of an analogous non-expos

Re: [blink-dev] Re: Intent to Ship: Expose ReadableStreamDefaultController interface

2022-07-11 Thread Domenic Denicola
Hey all, Today I was browsing https://wpt.fyi/results/streams?label=experimental&label=master&aligned and noticed that we were failing tests because of an analogous non-exposure of TransformStreamDefaultController. I have a CL to fix this at https://chromium-review.googlesource.com/c/chromium