Re: [blink-dev] Re: Intent to Ship: Attribution Reporting Feature: Attribution Scopes

2024-10-03 Thread Yoav Weiss (@Shopify)
LGTM3 On Wed, Oct 2, 2024 at 7:28 PM Mike Taylor wrote: > Thanks Akash - these changes help me better understand the features > (especially the links to how registration / reporting works). > > LGTM2 > On 10/2/24 1:09 PM, 'Akash Nadan' via blink-dev wrote: > > Hi All, > > I just wanted to flag t

Re: [blink-dev] Re: Intent to Ship: Attribution Reporting Feature: Attribution Scopes

2024-10-02 Thread Mike Taylor
Thanks Akash - these changes help me better understand the features (especially the links to how registration / reporting works). LGTM2 On 10/2/24 1:09 PM, 'Akash Nadan' via blink-dev wrote: Hi All, I just wanted to flag that we have also updated the example with diagrams that better show a

[blink-dev] Re: Intent to Ship: Attribution Reporting Feature: Attribution Scopes

2024-10-02 Thread 'Akash Nadan' via blink-dev
Hi All, I just wanted to flag that we have also updated the example with diagrams that better show a comparison of the behavior before vs. after using this feature: https://github.com/WICG/attribution-reporting-api/blob/main/attribution_scopes.md#attribution-scope-examples Thanks, Akash On Fr

[blink-dev] Re: Intent to Ship: Attribution Reporting Feature: Attribution Scopes

2024-09-27 Thread 'Akash Nadan' via blink-dev
Hi Alex, We have updated the code in that example to now show a comparison of the behavior before vs. after using this feature: https://github.com/WICG/attribution-reporting-api/blob/main/attribution_scopes.md#example-1-distinct-attribution-scopes-comparison-with-attribution-filters

[blink-dev] Re: Intent to Ship: Attribution Reporting Feature: Attribution Scopes

2024-09-26 Thread Alex Russell
Hey Akash, That example was the one I was referring to when asking for more. This doesn't show a full in-situ example of how to use this or what code would have been necessary before (or what the "before" code's deficiencies were). Best, Alex On Thu, Sep 26, 2024 at 11:07 AM Akash Nadan wrote:

[blink-dev] Re: Intent to Ship: Attribution Reporting Feature: Attribution Scopes

2024-09-26 Thread 'Akash Nadan' via blink-dev
Hi Alex, We have the following end-to-end example in the explainer that shows how this would work for a more real example: https://github.com/WICG/attribution-reporting-api/blob/main/attribution_scopes.md#attribution-scope-examples Let me know if you have any questions on the example! We are al

[blink-dev] Re: Intent to Ship: Attribution Reporting Feature: Attribution Scopes

2024-09-25 Thread Alex Russell
Hey Akash, This looks pretty uncontroversial, but I'm not sure from the Explainer how this fits together in an end-to-end scenario. Is there a fuller chunk of example code you could point me at? Or update the explainer to show how this works in practice? Best, Alex On Tuesday, September 10,