Re: [blink-dev] PSA: Throw exception when text encode alloc memory fail.

2024-08-06 Thread Dave Tapuska
Does it make sense to put it behind a feature flag? I know an OOM is terminal, I'm just wondering if something could have a side effect of not OOMing and removing some state when the exception fires instead. dave. On Mon, Aug 5, 2024 at 12:51 AM Adam Rice wrote: > Could it be a bug in the TextE

Re: [blink-dev] PSA: Throw exception when text encode alloc memory fail.

2024-08-04 Thread Adam Rice
> > Could it be a bug in the TextEncoding that is asking for a very large > allocation size? I've checked the code

Re: [blink-dev] PSA: Throw exception when text encode alloc memory fail.

2024-08-02 Thread Dave Tapuska
If you look at the OOM handler of Windows version in PartitionAlloc we do not debug alias the size of allocation. So

Re: [blink-dev] PSA: Throw exception when text encode alloc memory fail.

2024-08-02 Thread Yoav Weiss (@Shopify)
On Fri, Aug 2, 2024 at 11:40 AM Adam Rice wrote: > Usually specs don't cover what happens when you run out of memory, as > implied by https://infra.spec.whatwg.org/#algorithm-limits. I think > this is fine. I'm interested in what other browsers do, but it's hard to > test unless you have a VM han

Re: [blink-dev] PSA: Throw exception when text encode alloc memory fail.

2024-08-02 Thread Adam Rice
Usually specs don't cover what happens when you run out of memory, as implied by https://infra.spec.whatwg.org/#algorithm-limits. I think this is fine. I'm interested in what other browsers do, but it's hard to test unless you have a VM handy. On Fri, 2 Aug 2024 at 01:17, Mike Taylor wrote: > Hi

Re: [blink-dev] PSA: Throw exception when text encode alloc memory fail.

2024-08-01 Thread Mike Taylor
Hi there, Have we done any sort of web compatibility analysis of what this change implies? A broken page might be a better choice than a crashed tab, but it's hard to know without any sense of the potential impact of this change. Also, is there a plan to specify this behavior? What's the inte

[blink-dev] PSA: Throw exception when text encode alloc memory fail.

2024-08-01 Thread 'xu ms' via blink-dev
*Contact emails*: xuzha...@microsoft.com *Summary:* We are currently observing many renderer crashes occurring in text encode.Encoding Standard (whatwg.org) This is because DOMArrayBuffer::Create is currently used to create a buffer, and when memory allocati