Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-12-15 Thread 'Sonja Laurila' via blink-dev
Hey, This feature has also been implemented for ChromeOS and I was wondering if it needs a separate I2S or if it should go with this same one? Most of the WML implementation worked for CrOS already just by adding CrOS to the about flag definition and to the directive conditions, e.g. reading t

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-12-09 Thread Diego González
Hola Mike, That is a very valid point. We've renamed the boundingRect attribute to titlebarAreaRect to remove any ambiguity regarding the area being referenced. The change has now been merged. Thanks! Diego On Thursday, 9 December 2021 at 14:33:09 UTC mike...@chromium.org wrote: > I did,

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-12-09 Thread Mike West
I believe @Mike Taylor had some questions around spelling decisions in the API in our last API owners meeting. Mike, did you have a chance to look into that more deeply? -mike On Wed, Dec 8, 2021 at 11:00 PM Chris Harrelson wrote: > LGTM2 > > On Tue, Dec 7, 2021 at 2:36 AM Yoav Weiss wrote:

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-12-08 Thread Chris Harrelson
LGTM2 On Tue, Dec 7, 2021 at 2:36 AM Yoav Weiss wrote: > *LGTM1* > Thanks for driving those discussions and making the spec interoperable in > the process. > > On Tuesday, December 7, 2021 at 11:07:21 AM UTC+1 Diego González wrote: > >> Just as a heads up, all concerns have been addressed and th

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-12-07 Thread Yoav Weiss
*LGTM1* Thanks for driving those discussions and making the spec interoperable in the process. On Tuesday, December 7, 2021 at 11:07:21 AM UTC+1 Diego González wrote: > Just as a heads up, all concerns have been addressed and the latest > version of the spec is in a state where I believe we are

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-12-07 Thread Diego González
Just as a heads up, all concerns have been addressed and the latest version of the spec is in a state where I believe we are all happy with. Thanks for all the feedback and comments! On Wednesday, 1 December 2021 at 18:26:03 UTC luig...@microsoft.com wrote: > There is a PR waiting to be merged

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-12-01 Thread 'Diego Gonzalez' via blink-dev
There is a PR waiting to be merged that adds a note about developers using reasonable fallbacks on unsupported browsers, I will let you know once it gets merged. On Wednesday, 1 December 2021 at 17:29:03 UTC Diego González wrote: > YUC. 😉 > > If a developer has used the environmental variables

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-12-01 Thread Diego González
YUC. 😉 If a developer has used the environmental variables and the web app gets installed in browser that does not support it (then it is a parallel universe because Firefox nor Safari nor other desktop browser supports this *kidding*) then they can specify reasonable fallback values because th

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-12-01 Thread Yoav Weiss
On Tuesday, November 30, 2021 at 6:48:07 PM UTC+1 Diego González wrote: > Hola Yoav, > > I wanted to add that we implemented the concept of a display-override to > control the fallback of display modes. For non supported browsers, > developers can also specify the display-override and even if

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-11-30 Thread Diego González
Hola Yoav, I wanted to add that we implemented the concept of a display-override to control the fallback of display modes. For non supported browsers, developers can also specify the display-override and even if this is not supported it will default to the display value in the manifest file.

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-11-29 Thread Diego González
Hola Yoav, For non supported browsers there are 2 options: - env variables take the specified default value by developers (if devs enable WCO). - The web app will open as it would in the browser, with a titlebar if installed (if devs don't enable WCO). WCO is enabled by the en

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-11-18 Thread Yoav Weiss
This looks great! Thanks for following up on the spec work!! I had a couple more questions upthread: - What are developers expected to do in non-supporting browsers? - Would the user need to opt-in to having web app control over their title bar? On Fri, Nov 19, 2021 at 1:25 AM Diego Go

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-11-18 Thread Diego González
the the new *new* spec update https://wicg.github.io/window-controls-overlay/ On Wednesday, 17 November 2021 at 19:06:24 UTC Diego González wrote: > Hola, > > See the updated spec here: https://wicg.github.io/window-controls-overlay > . > > Thanks > > > On Monday, 15 November 2021 at 17:00:34 U

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-11-17 Thread Diego González
Hola, See the updated spec here: https://wicg.github.io/window-controls-overlay. Thanks On Monday, 15 November 2021 at 17:00:34 UTC Ajay Rahatekar wrote: > cc: ajayra...@google.com > > On Monday, November 15, 2021 at 8:53:37 AM UTC-8 Diego González wrote: > >> Hola Yoav, I am looking at makin

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-11-15 Thread 'Ajay Rahatekar' via blink-dev
cc: ajayrahate...@google.com On Monday, November 15, 2021 at 8:53:37 AM UTC-8 Diego González wrote: > Hola Yoav, I am looking at making the amendments listed on the github > issues. I will update soon with the changes. Thanks > > On Monday, 15 November 2021 at 08:44:41 UTC yoav...@chromium.org

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-11-15 Thread Diego González
Hola Yoav, I am looking at making the amendments listed on the github issues. I will update soon with the changes. Thanks On Monday, 15 November 2021 at 08:44:41 UTC yoav...@chromium.org wrote: > Thanks Diego! The updates are a great improvement, but I suspect are not > sufficient for an inter

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-11-15 Thread Yoav Weiss
Thanks Diego! The updates are a great improvement, but I suspect are not sufficient for an interoperable implementation. I left a couple of comments on the open issues. On Wed, Nov 10, 2021 at 5:11 PM Diego González wrote: > Hola Yoav, > > We've gone through several iterations of the WCO spec re

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-11-10 Thread Diego González
Hola Yoav, We've gone through several iterations of the WCO spec reviewed by Joshua Bell from Google, and while we are still making changes to it, we believe it is in a much better state and want to resubmit for consideration of the approvals needed for I2S. See the updated spec below: https:/

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-10-21 Thread Yoav Weiss
On Thursday, October 21, 2021 at 9:31:23 AM UTC+2 Yoav Weiss wrote: > This is an exciting improvement to PWA parity with native apps! :) > > On Wed, Oct 20, 2021 at 10:49 PM 'Diego Gonzalez' via blink-dev < > blink-dev@chromium.org> wrote: > >> Contact emails >> >> amb...@microsoft.com, luigo.

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-10-21 Thread Alex Russell
I think this is a great question, but somewhat out of scope for the Intent. Please ping your local design/security teams ;-) On Thursday, October 21, 2021 at 4:19:24 AM UTC-7 Thomas Steiner wrote: > Any plans to move the ﹀ icon into the three dots menu? It looks a bit > ugly. There is an experi

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-10-21 Thread 'Thomas Steiner' via blink-dev
Any plans to move the ﹀ icon into the three dots menu? It looks a bit ugly. There is an experiment to move the puzzle piece into the three dots menu, too, so maybe this icon could be there, too? Maybe after the user has toggled it for the first time to not hurt discoverability of WCO (even further)

Re: [blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-10-21 Thread Yoav Weiss
This is an exciting improvement to PWA parity with native apps! :) On Wed, Oct 20, 2021 at 10:49 PM 'Diego Gonzalez' via blink-dev < blink-dev@chromium.org> wrote: > Contact emails > > amb...@microsoft.com, luigo...@microsoft.com, hata...@microsoft.com, > c...@chromium.org > > > Explainer > > htt

[blink-dev] Intent to Ship: Window Controls Overlay for Installed Desktop Web Apps

2021-10-20 Thread 'Diego Gonzalez' via blink-dev
Contact emails amb...@microsoft.com, luigo...@microsoft.com, hata...@microsoft.com, c...@chromium.org Explainer https://github.com/WICG/window-controls-overlay/blob/master/expla