Re: [blink-dev] Intent to Ship: Select parser relaxation

2024-10-11 Thread Joey Arhar
> This PR is still getting pretty active review comments. At least some of them seem like they'll impact the behavior. Do you think it would be reasonable to wait for the PR to settle before approving? I don't think we necessarily need to wait for formal approval or merging, but it seems like right

Re: [blink-dev] Intent to Ship: Select parser relaxation

2024-10-11 Thread Vladimir Levin
LGTM3 On Fri, Oct 11, 2024 at 3:12 PM Chris Harrelson wrote: > LGTM2 > > I think it makes sense at this point to start finching/turning on this API > freely on the stable channel, in order to inform the final spec > language and landed PR. This is also the main risk factor identified in the > Mo

Re: [blink-dev] Intent to Ship: Select parser relaxation

2024-10-11 Thread Chris Harrelson
LGTM2 I think it makes sense at this point to start finching/turning on this API freely on the stable channel, in order to inform the final spec language and landed PR. This is also the main risk factor identified in the Mozilla standards position request. I think this is inherently a chicken-and

Re: [blink-dev] Intent to Ship: Select parser relaxation

2024-10-11 Thread Alex Russell
I agree with Domenic about TAG risk; just flagging this as part of the larger package is great. Will the rollout of this change be Finch controlled? Do you expect the launch to happen over a single release? If you do a partial rollout for compat reasons and it goes sideways, please let us know.

Re: [blink-dev] Intent to Ship: Select parser relaxation

2024-10-10 Thread Domenic Denicola
On Fri, Oct 11, 2024 at 5:33 AM Joey Arhar wrote: > Contact emailsjar...@chromium.org > > Explainerhttps://open-ui.org/components/customizableselect > > Specificationhttps://github.com/whatwg/html/pull/10557 > This PR is still getting pretty active review comments. At least some of them seem lik

[blink-dev] Intent to Ship: Select parser relaxation

2024-10-10 Thread Joey Arhar
Contact emailsjar...@chromium.org Explainerhttps://open-ui.org/components/customizableselect Specificationhttps://github.com/whatwg/html/pull/10557 Summary This change makes the HTML parser allow additional tags in besides , , and . This change is in support of the customizable feature but is