Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-09-13 Thread Koji Ishii
On Thu, Sep 14, 2023 at 12:14 AM Philip Jägenstedt wrote: > If there is feedback on the TAG review or Mozilla issue while this feature > is on its way to stable, can you loop back to this thread? > Yes, I will. Thank you all. > -- You received this message because you are subscribed to the Go

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-09-13 Thread Mike Taylor
LGTM3 On 9/13/23 5:46 PM, Daniel Bratell wrote: LGTM2 /Daniel On 2023-09-13 17:14, Philip Jägenstedt wrote: LGTM1 If there is feedback on the TAG review or Mozilla issue while this feature is on its way to stable, can you loop back to this thread? On Thu, Sep 7, 2023 at 4:01 PM Philip Jä

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-09-13 Thread Daniel Bratell
LGTM2 /Daniel On 2023-09-13 17:14, Philip Jägenstedt wrote: LGTM1 If there is feedback on the TAG review or Mozilla issue while this feature is on its way to stable, can you loop back to this thread? On Thu, Sep 7, 2023 at 4:01 PM Philip Jägenstedt wrote: Thanks for investigating an

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-09-13 Thread Philip Jägenstedt
LGTM1 If there is feedback on the TAG review or Mozilla issue while this feature is on its way to stable, can you loop back to this thread? On Thu, Sep 7, 2023 at 4:01 PM Philip Jägenstedt wrote: > Thanks for investigating and fixing the failures, Koji! > > On the UA defined rules, if other ven

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-09-07 Thread Philip Jägenstedt
Thanks for investigating and fixing the failures, Koji! On the UA defined rules, if other vendors are happy with the examples used, then that's what matters in practice. If you do get pushback on specific examples I hope there are others that can be used that are a common ground. I think everythi

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-09-07 Thread Koji Ishii
I've got two updates on the questions: On Thu, Sep 7, 2023 at 2:46 AM Koji Ishii wrote: > Good point, thanks for asking. > > Technically speaking, we can't write any tests because the > language-specific content analysis is UA defined. Tests use common and easy > words that most engines would an

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-09-06 Thread Koji Ishii
Good point, thanks for asking. Technically speaking, we can't write any tests because the language-specific content analysis is UA defined. Tests use common and easy words that most engines would analyze the same way, but you're right that we may need to modify tests if any engine analyzes them di

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-09-06 Thread Philip Jägenstedt
Hi Koji, It looks like the tests for this are here: https://wpt.fyi/results/css/css-text/word-break/auto-phrase?label=experimental&label=master&aligned Since the implementation uses a heuristic and the spec doesn't define the precise rules, can you say something about the approach taken in the te

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-09-01 Thread Koji Ishii
On Fri, Sep 1, 2023 at 11:53 PM Mike Taylor wrote: > *Gecko*: No signal > > Can we request one? > Done, https://github.com/mozilla/standards-positions/issues/877 -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-09-01 Thread Mike Taylor
On 9/1/23 9:53 AM, Mike Taylor wrote: On 9/1/23 12:59 AM, Koji Ishii wrote: Contact emails ko...@chromium.org Explainer None Specification https://drafts.csswg.org/css-text-4/#valdef-word-break-auto-phrase Design docs https://docs.google.com/document

Re: [blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-09-01 Thread Mike Taylor
On 9/1/23 12:59 AM, Koji Ishii wrote: Contact emails ko...@chromium.org Explainer None Specification https://drafts.csswg.org/css-text-4/#valdef-word-break-auto-phrase Design docs https://docs.google.com/document/d/1QyPza8XS4aaYD-yA1MHYx56Hy7DZuEm9cAH-

[blink-dev] Intent to Ship: Japanese Phrase Line Breaking

2023-08-31 Thread Koji Ishii
Contact emailsko...@chromium.org ExplainerNone Specification https://drafts.csswg.org/css-text-4/#valdef-word-break-auto-phrase Design docs https://docs.google.com/document/d/1QyPza8XS4aaYD-yA1MHYx56Hy7DZuEm9cAH-A6lTu8c/edit?usp=sharing Summary Changes the line breaking rules for Japanese to k