Re: [blink-dev] Intent to Ship: Dispatching click events to captured pointer

2025-02-12 Thread Rick Byers
Ok, thank you - glad to hear it's unrelated to tap. This seems almost bugfix-level to me then, unlikely to be a compat problem in practice despite the somewhat surprisingly large use of setPointerCapture. Rick On Wed, Feb 12, 2025 at 3:17 PM Mustaq Ahmed wrote: > This feature and the UseCounter

Re: [blink-dev] Intent to Ship: Dispatching click events to captured pointer

2025-02-12 Thread Mustaq Ahmed
This feature and the UseCounter stats mentioned above are for mouse clicks only. So GestureTap clicks are not a concern at the m

Re: [blink-dev] Intent to Ship: Dispatching click events to captured pointer

2025-02-12 Thread Rick Byers
LGTM3 I was surprised the UseCounter was so high, is that because this includes the implicit capture case for touch input? Or is setPointerCapture really that common? If it includes the touch implicit capture case, does that mean the click generated from a GestureTap can also have it's target chan

Re: [blink-dev] Intent to Ship: Dispatching click events to captured pointer

2025-02-11 Thread Chris Harrelson
LGTM2 On Sun, Feb 9, 2025 at 7:56 PM Domenic Denicola wrote: > > > On Sat, Feb 8, 2025 at 5:29 AM Mustaq Ahmed wrote: > >> My i2s message missed one important point: we are planning for an >> incremental rollout on Stable, just to be on the safe side from the compat >> perspective (see my WIP f

Re: [blink-dev] Intent to Ship: Dispatching click events to captured pointer

2025-02-09 Thread Domenic Denicola
On Sat, Feb 8, 2025 at 5:29 AM Mustaq Ahmed wrote: > My i2s message missed one important point: we are planning for an > incremental rollout on Stable, just to be on the safe side from the compat > perspective (see my WIP finch config cl/721367851 >

Re: [blink-dev] Intent to Ship: Dispatching click events to captured pointer

2025-02-07 Thread Mustaq Ahmed
My i2s message missed one important point: we are planning for an incremental rollout on Stable, just to be on the safe side from the compat perspective (see my WIP finch config cl/721367851, sorry internal link). > To move everyone toward interop, I suggest commenting on https://bugzilla.mozilla.

Re: [blink-dev] Intent to Ship: Dispatching click events to captured pointer

2025-02-05 Thread Domenic Denicola
LGTM1. This seems like a valuable movement toward interop on tricky edge-cases, and the team has done a good job with use counters and beta experiments to bound the compat risks. I think Finch can be used as a killswitch if we find that this has some horrible breaking impact that has not yet been d

Re: [blink-dev] Intent to Ship: Dispatching click events to captured pointer

2025-02-05 Thread Mustaq Ahmed
Hi Mike and Yoav: Let me answer your questions together: *Current behavior in major browsers:* The click target is: - [Chrome] the common ancestor of pointerdown target and *captured* pointerup target. - [Firefox] the actual pointerup target, ignoring capture and pointerdown. - [Safari] the commo

Re: [blink-dev] Intent to Ship: Dispatching click events to captured pointer

2025-02-05 Thread Yoav Weiss (@Shopify)
On Wed, Feb 5, 2025 at 4:11 PM Mustaq Ahmed wrote: > Contact emailsmus...@chromium.org > > Explainerhttps://w3c.github.io/pointerevents/#event-dispatch > > Specificationhttps://w3c.github.io/pointerevents/#event-dispatch > > Summary > > If a pointer is captured while the `pointerup` event is bein

Re: [blink-dev] Intent to Ship: Dispatching click events to captured pointer

2025-02-05 Thread Mike Taylor
On 2/5/25 10:11 AM, Mustaq Ahmed wrote: Contact emails mus...@chromium.org Explainer https://w3c.github.io/pointerevents/#event-dispatch Specification https://w3c.github.io/pointerevents/#event-dispatch Summary If a p

[blink-dev] Intent to Ship: Dispatching click events to captured pointer

2025-02-05 Thread Mustaq Ahmed
Contact emailsmus...@chromium.org Explainerhttps://w3c.github.io/pointerevents/#event-dispatch Specificationhttps://w3c.github.io/pointerevents/#event-dispatch Summary If a pointer is captured while the `pointerup` event is being dispatched, the `click` event will be dispatched to the captured