Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-21 Thread Yoav Weiss (@Shopify)
Wait no, these should be LGTM2 and LGTM3 On Wed, May 21, 2025 at 6:35 PM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM2 > > On Wed, May 21, 2025 at 6:34 PM Vladimir Levin > wrote: > >> CSSWG resolved on this issue >> https://github.com/w3c/csswg-drafts/issues/10982#issuecomment-2

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-21 Thread Vladimir Levin
Correction: LGTM2, because of Mike Taylor's approval above On Wednesday, May 21, 2025 at 12:34:48 PM UTC-4 Vladimir Levin wrote: > CSSWG resolved on this issue > https://github.com/w3c/csswg-drafts/issues/10982#issuecomment-2898572289 > I believe this aligns with option 2 in Yoav's reply. > > L

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-21 Thread Yoav Weiss (@Shopify)
LGTM2 On Wed, May 21, 2025 at 6:34 PM Vladimir Levin wrote: > CSSWG resolved on this issue > https://github.com/w3c/csswg-drafts/issues/10982#issuecomment-2898572289 > I believe this aligns with option 2 in Yoav's reply. > > LGTM1 > > Thanks, > Vlad > On Wednesday, May 21, 2025 at 3:48:18 AM UTC

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-21 Thread Vladimir Levin
CSSWG resolved on this issue https://github.com/w3c/csswg-drafts/issues/10982#issuecomment-2898572289 I believe this aligns with option 2 in Yoav's reply. LGTM1 Thanks, Vlad On Wednesday, May 21, 2025 at 3:48:18 AM UTC-4 Rune Lillesveen wrote: > On Tue, May 20, 2025 at 1:38 PM Yoav Weiss (@Sho

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-21 Thread Rune Lillesveen
On Tue, May 20, 2025 at 1:38 PM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > > > On Tue, May 20, 2025 at 1:32 PM Rune Lillesveen > wrote: > >> On Tue, May 20, 2025 at 10:47 AM Yoav Weiss (@Shopify) < >> yoavwe...@chromium.org> wrote: >> >>> >>> >>> On Wed, May 14, 2025 at 6:10 PM Phil

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-20 Thread Yoav Weiss (@Shopify)
On Tue, May 20, 2025 at 1:32 PM Rune Lillesveen wrote: > On Tue, May 20, 2025 at 10:47 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> >> >> On Wed, May 14, 2025 at 6:10 PM Philip Jägenstedt >> wrote: >> >>> On Wed, May 14, 2025 at 5:21 PM Rune Lillesveen >>> wrote: >>> On

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-20 Thread Rune Lillesveen
On Tue, May 20, 2025 at 10:47 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > > > On Wed, May 14, 2025 at 6:10 PM Philip Jägenstedt > wrote: > >> On Wed, May 14, 2025 at 5:21 PM Rune Lillesveen >> wrote: >> >>> On Tue, May 13, 2025 at 9:20 AM Rune Lillesveen >>> wrote: >>> On T

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-20 Thread Yoav Weiss (@Shopify)
On Wed, May 14, 2025 at 6:10 PM Philip Jägenstedt wrote: > On Wed, May 14, 2025 at 5:21 PM Rune Lillesveen > wrote: > >> On Tue, May 13, 2025 at 9:20 AM Rune Lillesveen >> wrote: >> >>> On Tue, May 13, 2025 at 8:34 AM Rune Lillesveen >>> wrote: >>> On Tue, May 13, 2025 at 7:43 AM Domenic

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-14 Thread Philip Jägenstedt
On Wed, May 14, 2025 at 5:21 PM Rune Lillesveen wrote: > On Tue, May 13, 2025 at 9:20 AM Rune Lillesveen > wrote: > >> On Tue, May 13, 2025 at 8:34 AM Rune Lillesveen >> wrote: >> >>> On Tue, May 13, 2025 at 7:43 AM Domenic Denicola >>> wrote: >>> I'm very slightly worried about the cases

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-14 Thread Rune Lillesveen
On Tue, May 13, 2025 at 9:20 AM Rune Lillesveen wrote: > On Tue, May 13, 2025 at 8:34 AM Rune Lillesveen > wrote: > >> On Tue, May 13, 2025 at 7:43 AM Domenic Denicola >> wrote: >> >>> I'm very slightly worried about the cases which we seem to accept, but >>> the latest on the CSSWG thread sugg

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-13 Thread Rune Lillesveen
On Tue, May 13, 2025 at 8:34 AM Rune Lillesveen wrote: > On Tue, May 13, 2025 at 7:43 AM Domenic Denicola > wrote: > >> I'm very slightly worried about the cases which we seem to accept, but >> the latest on the CSSWG thread suggests we should disallow. Namely, >> @container and @page. How sure

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-12 Thread Rune Lillesveen
On Tue, May 13, 2025 at 7:43 AM Domenic Denicola wrote: > I'm very slightly worried about the cases which we seem to accept, but the > latest on the CSSWG thread suggests we should disallow. Namely, @container > and @page. How sure are you that changing those to be invalid in the > future, to fol

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-12 Thread Domenic Denicola
I'm very slightly worried about the cases which we seem to accept, but the latest on the CSSWG thread suggests we should disallow. Namely, @container and @page. How sure are you that changing those to be invalid in the future, to follow the latest CSSWG decisions, will not cause compat problems

Re: [blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-12 Thread Mike Taylor
LGTM1 On 5/9/25 9:47 AM, Rune Lillesveen wrote: Contact emails futh...@chromium.org, se...@chromium.org Explainer https://github.com/w3c/csswg-drafts/blob/main/css-values-5/tree-counting-explainer.md Specification https://drafts.csswg.

[blink-dev] Intent to Ship: CSS sibling-index() and sibling-count()

2025-05-09 Thread Rune Lillesveen
Contact emailsfuth...@chromium.org, se...@chromium.org Explainer https://github.com/w3c/csswg-drafts/blob/main/css-values-5/tree-counting-explainer.md Specificationhttps://drafts.csswg.org/css-values-5/#tree-counting Design docs https://github.com/w3c/csswg-drafts/blob/main/css-values-5/tree-cou