Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-27 Thread Stefan Zager
I removed 'tentative' from the test name (PR ). On Thu, Feb 15, 2024 at 6:15 PM Mike Taylor wrote: > LGTM3, with the same conditions from Chris. > On 2/15/24 6:15 PM, Chris Harrelson wrote: > > LGTM2, conditioned on also making the tests Rego

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-15 Thread Mike Taylor
LGTM3, with the same conditions from Chris. On 2/15/24 6:15 PM, Chris Harrelson wrote: LGTM2, conditioned on also making the tests Rego mentioned non-tentative. On Mon, Feb 12, 2024 at 11:05 AM Stefan Zager wrote: Done (requested N/A). On Mon, Feb 12, 2024 at 3:05 AM Manuel Rego Casa

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-15 Thread Chris Harrelson
LGTM2, conditioned on also making the tests Rego mentioned non-tentative. On Mon, Feb 12, 2024 at 11:05 AM Stefan Zager wrote: > Done (requested N/A). > > On Mon, Feb 12, 2024 at 3:05 AM Manuel Rego Casasnovas > wrote: > >> Oops, before we can approve you have to fill the other review gates at

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-12 Thread Stefan Zager
Done (requested N/A). On Mon, Feb 12, 2024 at 3:05 AM Manuel Rego Casasnovas wrote: > Oops, before we can approve you have to fill the other review gates at > chromestatus, e.g. > https://chromestatus.com/feature/5178467903864832?gate=5166816630669312 > > Could you make sure you request the revi

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-12 Thread Manuel Rego Casasnovas
Oops, before we can approve you have to fill the other review gates at chromestatus, e.g. https://chromestatus.com/feature/5178467903864832?gate=5166816630669312 Could you make sure you request the review for all the gates: Privacy, Security, Enterprise, Debuggability and Testing? Thanks!

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-12 Thread Manuel Rego Casasnovas
LGTM1. Good to know it's a different issue in Firefox. Now that all browsers will be supporting this, please could you make the test non tentative? JFYI, I've filled an issue so the MDN documentation gets updated to also include the HTML case: https://github.com/mdn/content/issues/32236 Ch

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-09 Thread Stefan Zager
On Thu, Feb 8, 2024 at 4:00 AM Manuel Rego Casasnovas wrote: > Why is the WPT test marked as tentative? > https://wpt.fyi/results/css/css-fill-stroke/paint-order-001.tentative.html > > Not sure if there are more tests or is only that one, but it's failing > in Firefox. What are the interop issues

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-08 Thread Manuel Rego Casasnovas
Why is the WPT test marked as tentative? https://wpt.fyi/results/css/css-fill-stroke/paint-order-001.tentative.html Not sure if there are more tests or is only that one, but it's failing in Firefox. What are the interop issues? Are those reported somewhere? Thanks, Rego On 08/02/2024 11:48,

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-08 Thread Fredrik Söderquist
On Thu, Feb 8, 2024 at 11:30 AM Daniel Bratell wrote: > I didn't really get how it affects non-SVG text. The documentation and the > examples are all for SVG. Is there HTML text that is also a mix of stroke, > fill and marker blitting? > Here's an example for non-SVG (HTML) text: https://jsfiddle

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-08 Thread Daniel Bratell
I didn't really get how it affects non-SVG text. The documentation and the examples are all for SVG. Is there HTML text that is also a mix of stroke, fill and marker blitting? /Daniel On 2024-02-08 10:14, Fredrik Söderquist wrote: On Thu, Feb 8, 2024 at 2:48 AM Stefan Zager wrote:

Re: [blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-08 Thread Fredrik Söderquist
On Thu, Feb 8, 2024 at 2:48 AM Stefan Zager wrote: > Contact emailssza...@chromium.org > > Explainerhttps://developer.mozilla.org/en-US/docs/Web/CSS/paint-order > > Specificationhttps://svgwg.org/svg2-draft/painting.html#PaintOrder > > Summary > > Adds support for the existing CSS property `paint

[blink-dev] Intent to Ship: CSS paint-order for non-SVG text

2024-02-07 Thread Stefan Zager
Contact emailssza...@chromium.org Explainerhttps://developer.mozilla.org/en-US/docs/Web/CSS/paint-order Specificationhttps://svgwg.org/svg2-draft/painting.html#PaintOrder Summary Adds support for the existing CSS property `paint-order`. This change only affects html (non-SVG) text; SVG text alr