Re: [Bitcoin-development] Transaction limit size in CWallet::CreateTransaction

2011-09-03 Thread Chris Double
On Sun, Sep 4, 2011 at 1:52 AM, Chris Double wrote: > So was the intent to use the CWalletTxn size, and the casting is > superfluous, or was it supposed to be the CTransaction* portion and > the cast is an incorrect way of doing that? Or am I suffering from > late night programmer syndrome and rea

[Bitcoin-development] Transaction limit size in CWallet::CreateTransaction

2011-09-03 Thread Chris Double
In CWallet::CreateTransaction there is a call to 'GetSerializeSize' on line 979 (https://github.com/bitcoin/bitcoin/blob/master/src/wallet.cpp#L979). It looks like: -8<-- unsigned int nBytes = ::GetSerializeSize(*(CTransaction*)&wtxNew, SER_NETWORK) if (nBytes >= MAX_BLOCK_SIZE_GEN