Re: [Bitcoin-development] Payment Protocol Hash Comments

2014-03-03 Thread Drak
On 2 March 2014 10:39, Mike Hearn wrote: > I'm just repeating the rationale Gavin gave me for adding this to the spec > last year when he was implementing it. Perhaps it only applied to some > versions of PHP or something like that. > OK, but certainly now, SHA-2 is available as standard in PHP

Re: [Bitcoin-development] Payment Protocol Hash Comments

2014-03-02 Thread Mike Hearn
I'm just repeating the rationale Gavin gave me for adding this to the spec last year when he was implementing it. Perhaps it only applied to some versions of PHP or something like that. Jeremy, good comments. A pull request to fix those would be good. One issue I seem looming on the horizon is th

Re: [Bitcoin-development] Payment Protocol Hash Comments

2014-03-02 Thread Drak
Not true, PHP does support sha2 http://php.net/manual/en/mhash.constants.php http://php.net/manual/en/function.hash-algos.php#refsect1-function.hash-algos-examples On 2 Mar 2014 08:44, "Mike Hearn" wrote: > SHA-1 support is there for PHP developers. Apparently it can't do SHA-2. > On 2 Mar 2014

Re: [Bitcoin-development] Payment Protocol Hash Comments

2014-03-02 Thread Mike Hearn
SHA-1 support is there for PHP developers. Apparently it can't do SHA-2. On 2 Mar 2014 08:53, "Jeremy Spilman" wrote: > From BIP70: > >If pki_type is "x509+sha256", then the Payment message is hashed using > the >SHA256 algorithm to produce the message digest that is signed. If > pki_typ

[Bitcoin-development] Payment Protocol Hash Comments

2014-03-01 Thread Jeremy Spilman
From BIP70: If pki_type is "x509+sha256", then the Payment message is hashed using the SHA256 algorithm to produce the message digest that is signed. If pki_type is "x509+sha1", then the SHA1 algorithm is used. A couple minor comments; - I think it meant to say the field to be ha