Re: [Bitcoin-development] Bug in key.cpp

2014-05-06 Thread Pieter Wuille
On Tue, May 6, 2014 at 5:12 AM, wrote: > You are right there is a bug in there. > > But the value is not 25% I think. Tinker some more. :-) > >> >> Afaict, 3 is a perfectly valid value, meaning 25% of sig-> key recoveries >> would fail erroneously... Values 2 and 3 are only needed in theory. Th

Re: [Bitcoin-development] Bug in key.cpp

2014-05-05 Thread odinn . cyberguerrilla
You are right there is a bug in there. But the value is not 25% I think. Tinker some more. :-) > I think i see a bug: > > line 273 of key.cpp > > if (rec<0 || rec>=3) > return false; > > Afaict, 3 is a perfectly valid value, meaning 25% of sig-> key recoveries > would fail er

[Bitcoin-development] Bug in key.cpp

2014-05-05 Thread Srintuar
I think i see a bug: line 273 of key.cpp if (rec<0 || rec>=3) return false; Afaict, 3 is a perfectly valid value, meaning 25% of sig-> key recoveries would fail erroneously... -- Is your legacy SCM sy