Re: [Bitcoin-development] BIP70/71 issue, RFD

2014-01-26 Thread Gavin
Message encoding and length (or terminator or checksum or error correction or...) should be part of the transport protocol, in my humble opinion. -- Gavin Andresen > On Jan 26, 2014, at 6:01 PM, Mike Hearn wrote: > > To be more accurate, the embedded messages already have length prefixes :-)

Re: [Bitcoin-development] BIP70/71 issue, RFD

2014-01-26 Thread Mike Hearn
To be more accurate, the embedded messages already have length prefixes :-) On Sun, Jan 26, 2014 at 11:14 PM, Andreas Schildbach wrote: > Just keep in mind that if it turns out we need to retrofit messages with > length prefixes I fear we will have to restart with new mime-types. The > nature of

Re: [Bitcoin-development] BIP70/71 issue, RFD

2014-01-26 Thread Andreas Schildbach
Just keep in mind that if it turns out we need to retrofit messages with length prefixes I fear we will have to restart with new mime-types. The nature of prefixes being always at the start means this rules out simply incrementing a protocol version number. Correcting myself: > it might be a good

Re: [Bitcoin-development] BIP70/71 issue, RFD

2014-01-26 Thread Mike Hearn
I think for "binding" the payment protocol to those transports we should indeed use protobuf varint length prefixes. But it's unnecessary for all cases. Unless Gavin feels it'd be better to be consistent everywhere and is willing to change the spec and code - as far as I know though we're trying to

Re: [Bitcoin-development] BIP70/71 issue, RFD

2014-01-26 Thread Andreas Schildbach
Bluetooth, Wifi Direct, HTTP request/responses via broken proxies, smoke signals... basically anything that is a stream rather than a file. Right, NFC NDEF and QR codes are not affected, so we can skip the delimiter for these mediums. On 01/26/2014 10:24 PM, Mike Hearn wrote: > Which medium is t

Re: [Bitcoin-development] BIP70/71 issue, RFD

2014-01-26 Thread Mike Hearn
Which medium is this an issue for? As you note, for files and HTTP responses it's not a problem in practice. i'd guess nor for NFC tags nor QR codes. On Sun, Jan 26, 2014 at 10:11 PM, Andreas Schildbach wrote: > I'm experimenting with BIP70/71 (payment protocol) usage in face to face > payments

[Bitcoin-development] BIP70/71 issue, RFD

2014-01-26 Thread Andreas Schildbach
I'm experimenting with BIP70/71 (payment protocol) usage in face to face payments (more on that soon). I've excountered an issue with the protobuf format. Protobufs are not self-delimiting. That means if you're reading from an undelimited stream, you will read endlessly because you don't know how