Re: [Bitcoin-development] 0.4rc1 known bugs

2011-09-07 Thread Gavin Andresen
On Tue, Sep 6, 2011 at 4:55 PM, Luke-Jr wrote: > Got a fix for the encrypted-wallet mining issue: > - unique_coinbase Turned this into a pull request: https://github.com/bitcoin/bitcoin/pull/505 I reviewed the code but have not tested. Rough sketch of a test plan: Run clean testnet-in-a-box

Re: [Bitcoin-development] 0.4rc1 known bugs

2011-09-06 Thread Luke-Jr
Got a fix for the encrypted-wallet mining issue: - unique_coinbase It depends on (and merges) the getwork_dedupe fix already common on pools and other miners who pay attention to the latest mining fixes. To merge: git fetch git://gitorious.org/~Luke-Jr/bitcoin/luke-jr-bitcoin.git \ unique_

Re: [Bitcoin-development] 0.4rc1 known bugs

2011-09-06 Thread Gavin Andresen
Nice work, Detective Wuille! Patch for the deadlock issue: https://github.com/bitcoin/bitcoin/pull/500 I took a different approach to fix from the one Pieter suggested, performing the database operation after the cs_mapaddresses deadlock is released. Please review to check my logic, it did surv

Re: [Bitcoin-development] 0.4rc1 known bugs

2011-09-06 Thread Pieter Wuille
On Sun, Sep 4, 2011 at 13:59, Pieter Wuille wrote: > I've compiled bitcoind with Gavin's DEBUG_LOCKORDER, and fixed two potential > reported deadlock issues (see > https://github.com/sipa/bitcoin/commits/lockfixes). My mistake: these are not actual potential deadlocks, as all locking of cs_vRecv

Re: [Bitcoin-development] 0.4rc1 known bugs

2011-09-05 Thread Michael Grønager
Sorry, by bad - first clean checkout for quite a while (must have changed it earlier myself...). /M On 05/09/2011, at 14:42, Luke-Jr wrote: > On Monday, September 05, 2011 3:25:47 AM Michael Grønager wrote: >> Findings - compile (I do not use the UPNP feature): >> in the makefile.unix I have to

Re: [Bitcoin-development] 0.4rc1 known bugs

2011-09-05 Thread Luke-Jr
On Monday, September 05, 2011 3:25:47 AM Michael Grønager wrote: > Findings - compile (I do not use the UPNP feature): > in the makefile.unix I have to change the: > USE_UPNP:=0 > to > USE_UPNP:= > i.e. it is defined if it is "0" ! Yes, the default is "UPnP supported, disabled by default" (USE_UPN

Re: [Bitcoin-development] 0.4rc1 known bugs

2011-09-05 Thread Michael Grønager
Hi Gavin, Did a quick compile and run (bitcoind, Ubuntu 10.04.3 LTS) Findings - compile (I do not use the UPNP feature): in the makefile.unix I have to change the: USE_UPNP:=0 to USE_UPNP:= i.e. it is defined if it is "0" ! running: no apparent issues (I have never managed to trigger the deadl

Re: [Bitcoin-development] 0.4rc1 known bugs]

2011-09-04 Thread Pieter Wuille
On Sat, Sep 03, 2011 at 08:13:14PM -0400, Gavin Andresen wrote: > Quick status update on 0.4; I probably won't have time to tackle these > properly before Tuesday: > > + sipa found what looks like a deadlock between the addr-handling and > IRC-join-handling code. I've compiled bitcoind with Gavin

Re: [Bitcoin-development] 0.4rc1 known bugs

2011-09-03 Thread Matt Corallo
On Sat, 2011-09-03 at 20:13 -0400, Gavin Andresen wrote: > Quick status update on 0.4; I probably won't have time to tackle these > properly before Tuesday: > > + sipa found what looks like a deadlock between the addr-handling and > IRC-join-handling code. > + UukGoblin reports a deadlock problem

[Bitcoin-development] 0.4rc1 known bugs

2011-09-03 Thread Gavin Andresen
Quick status update on 0.4; I probably won't have time to tackle these properly before Tuesday: + sipa found what looks like a deadlock between the addr-handling and IRC-join-handling code. + UukGoblin reports a deadlock problem on a bitcoind handling getwork requests. If you want to get more fam