Re: [Bitcoin-development] Newly introduced DoS

2011-09-26 Thread Gavin Andresen
> It's not future. It's presently allowed in blocks. Which means it's perfectly > valid to relay (and also perfectly value to NOT relay or accept). Ergo, > shouldn't be punished. You're absolutely right. And you're right about the 99 confirmations, too-- I was thinking blocks again, not transacti

Re: [Bitcoin-development] Newly introduced DoS

2011-09-26 Thread theymos
On Monday, September 26, 2011 5:53 PM, "Luke-Jr" wrote: > It's not future. It's presently allowed in blocks. Which means it's > perfectly valid to relay (and also perfectly value to NOT relay or > accept). Ergo, shouldn't be punished. Yeah, my node has always relayed these transactions. The limit

Re: [Bitcoin-development] Newly introduced DoS

2011-09-26 Thread Luke-Jr
On Monday, September 26, 2011 5:38:41 PM Gavin Andresen wrote: > > The first one I was referring to is a *transaction* with "non-standard" > > sig op count, which is AFAIK allowed in blocks, just not accepted by the > > mainline rules. > > I sit corrected. The context is: > // Checking ECDSA s

Re: [Bitcoin-development] Newly introduced DoS

2011-09-26 Thread Gavin Andresen
> The first one I was referring to is a *transaction* with "non-standard" sig op > count, which is AFAIK allowed in blocks, just not accepted by the mainline > rules. I sit corrected. The context is: // Checking ECDSA signatures is a CPU bottleneck, so to avoid denial-of-service // attacks

Re: [Bitcoin-development] Newly introduced DoS

2011-09-26 Thread Luke-Jr
On Monday, September 26, 2011 4:47:06 PM Gavin Andresen wrote: > On Mon, Sep 26, 2011 at 3:17 PM, Luke-Jr wrote: > > +return DoS(10, error("AcceptToMemoryPool() : transaction with > > out-of- bounds SigOpCount")); > > +return DoS(10, error("ConnectInputs() : tried t

Re: [Bitcoin-development] Newly introduced DoS

2011-09-26 Thread Gavin Andresen
On Mon, Sep 26, 2011 at 3:17 PM, Luke-Jr wrote: > +        return DoS(10, error("AcceptToMemoryPool() : transaction with out-of- > bounds SigOpCount")); > +                        return DoS(10, error("ConnectInputs() : tried to > spend coinbase at depth %d", pindexBlock->nHeight - pindex->nHeight

[Bitcoin-development] Deprecating "midstate" in getwork?

2011-09-26 Thread Nils Schneider
Hey, I'd like to simplify the internal reference miner and remove all dependencies on cryptopp (it's the only place we use cryptopp instead of OpenSSL). Unfortunately, cryptopp is also used to calculate getwork "midstate". This field is redundant and the miner could easily calculate it from the b

[Bitcoin-development] Miscommitted version

2011-09-26 Thread Luke-Jr
* 6b8a5ab Bump version to 0.4.1 This should be some pre-0.5.0, not 0.4.1 which will be the stable team's first release... -- All the data continuously generated in your IT infrastructure contains a definitive record of c

[Bitcoin-development] Newly introduced DoS

2011-09-26 Thread Luke-Jr
+return DoS(10, error("AcceptToMemoryPool() : transaction with out-of- bounds SigOpCount")); +return DoS(10, error("ConnectInputs() : tried to spend coinbase at depth %d", pindexBlock->nHeight - pindex->nHeight)); +return DoS(10, error("AcceptBlock() : prev