Re: [bitcoin-dev] BIP for Serverless Payjoin (AdamISZ)

2023-08-12 Thread Christopher Allen via bitcoin-dev
On Fri, Aug 11, 2023 at 3:29 PM symphonicbtc via bitcoin-dev < bitcoin-dev@lists.linuxfoundation.org> wrote: > Quick little nit I noticed as well, are you sure base64 encoding is the > best choice for the psk in the URI? You may find that having to urlencode > the special characters in base64 it i

Re: [bitcoin-dev] BIP for Serverless Payjoin (AdamISZ)

2023-08-11 Thread symphonicbtc via bitcoin-dev
Hey Dan, Very interested in such a protocol finally becoming standardized. Quick little nit I noticed as well, are you sure base64 encoding is the best choice for the psk in the URI? You may find that having to urlencode the special characters in base64 it impacts readability and adds a layer o

Re: [bitcoin-dev] BIP for Serverless Payjoin (AdamISZ)

2023-08-11 Thread Dan Gould via bitcoin-dev
Hi waxwing thanks for the detailed response. You've identified a number of flaws both in the protocol and the document that can be fixed. I sincerely appreciate it. If more comes to mind, fire away. > I wanted to immediately "nit" a point I saw as I was reading: > >> Because BIP 78 messages ar