Re: [bitcoin-dev] The new obfuscation patch & GetStats

2015-10-07 Thread Daniel Kraft via bitcoin-dev
Hi James! On 2015-10-08 02:29, James O'Beirne wrote: > This has been confirmed as a bug. Thanks again for reporting. I've filed > a fix here (https://github.com/bitcoin/bitcoin/pull/6777), and will be > writing tests to prevent regressions. Thanks for the quick fix! I thought to submit a patch m

Re: [bitcoin-dev] The new obfuscation patch & GetStats

2015-10-07 Thread James O'Beirne via bitcoin-dev
This has been confirmed as a bug. Thanks again for reporting. I've filed a fix here (https://github.com/bitcoin/bitcoin/pull/6777), and will be writing tests to prevent regressions. On Wed, Oct 7, 2015 at 4:32 PM, James O'Beirne wrote: > Hey, Daniel. > > Patch author here. Thanks for the diligen

Re: [bitcoin-dev] The new obfuscation patch & GetStats

2015-10-07 Thread James O'Beirne via bitcoin-dev
Hey, Daniel. Patch author here. Thanks for the diligence; I think this indeed may be an oversight, though I'm going to need to look into a bit more thoroughly at home. Curious that it didn't fail any of the automated tests. Correct me if I'm wrong, but the only actual invocation of that method is

[bitcoin-dev] The new obfuscation patch & GetStats

2015-10-07 Thread Daniel Kraft via bitcoin-dev
Hi! I hope this is not a stupid question, but I thought I'd ask here first instead of opening a Github ticket (in case I'm wrong). With the recently merged "obfuscation" patch, content of the "chainstate" LevelDB is obfuscated by XOR'ing against a random "key". This is handled by CLevelDBWrapper'