[Bit-team] [Bug 447841] Re: Soft links in snapshots should not be browseable

2009-11-29 Thread Dan
** Changed in: backintime Status: In Progress => Fix Committed -- Soft links in snapshots should not be browseable https://bugs.launchpad.net/bugs/447841 You received this bug notification because you are a member of Back In Time Team, which is subscribed to Back In Time. Status in Back I

[Bit-team] [Bug 447841] Re: Soft links in snapshots should not be browseable

2009-11-21 Thread Dan
- os.path.islink: tell us if is a symbolic link or not - os.path.exist: tell us if the target exists or is broken - os.readlink: we can get the link target (if is relative it does not start with '/') We can convert the target path to an absolute path and check if this path is inside current snaps

Re: [Bit-team] [Bug 447841] Re: Soft links in snapshots should not be browseable

2009-11-21 Thread Bart de Koning
I was thinking about this one: os.path.islink(*path*)ΒΆReturn True if *path* refers to a directory entry that is a symbolic link. Always False if symbolic links are not supported.But your one might indeed offer the possibility to distinguis

[Bit-team] [Bug 447841] Re: Soft links in snapshots should not be browseable

2009-11-19 Thread Bernat
For backup purposes I don't see any benefit in being able to browse links. It might be misleading indeed, think about restoring a directory link and its content, would it restore the real directory in addition to the directory link? My best solution would be making links non-browseable and show wh

[Bit-team] [Bug 447841] Re: Soft links in snapshots should not be browseable

2009-11-19 Thread Dan
Symlinks can be both absolute or relative. You can compare a symlink to a simple text file where is written the destination path. If the symlink is relative then the start point is the symlink path. Ex: path /abc/a cd /abc ln -s a b <= relative symlink to ./a ln -s /abc/a c => absolute symlink

Re: [Bit-team] [Bug 447841] Re: Soft links in snapshots should not be browseable

2009-11-19 Thread Bart de Koning
I could be wrong, but all copied symlinks point outside the snapshots or not? (they always link as /home/user/target, or do they use ../target?) There is a os python thingy that tests for symlinks, so it should be quite easy to set up a test... 2009/11/18 Dan > If the soft link is relative and i

[Bit-team] [Bug 447841] Re: Soft links in snapshots should not be browseable

2009-11-18 Thread Dan
If the soft link is relative and it point to a file/folder inside the snapshot that is can be nice to browse/open it. If it is outside I may look like it is inside ... so this is bad. OK, if the link is inside the snapshot (and it is not broken) the user should be able to open/browse it. If not i

[Bit-team] [Bug 447841] Re: Soft links in snapshots should not be browseable

2009-11-18 Thread Bart de Koning
I think we should disable softlink browsing, as they do not link to a position within the snapshot, but browse to a position outside of the snapshot giving the impression that that spot is also present in the snapshot while it is not. At least it should give a warning ** Changed in: backintime

[Bit-team] [Bug 447841] Re: Soft links in snapshots should not be browseable

2009-11-13 Thread Dan
Soft links are displayed italic and broken soft links italic with a bold '!' char before. ** Changed in: backintime Status: Confirmed => Fix Committed -- Soft links in snapshots should not be browseable https://bugs.launchpad.net/bugs/447841 You received this bug notification because you

[Bit-team] [Bug 447841] Re: Soft links in snapshots should not be browseable

2009-11-13 Thread Dan
Soft links are copied as soft links and it is true that Gnome version don't display them different. KDE version on the other hand display them italic. I agree that Gnome version should display them italic too. Even more, if the link is broken it should display it different too. -- Soft links in