Re: bgp proto bug with add paths in bird 1.6.3

2017-03-11 Thread Ondrej Zajicek
On Thu, Mar 09, 2017 at 03:20:59PM +0100, Ondrej Zajicek wrote: > Thanks for the bugreport and patch. We already found and fixed the bug > during work on 2.0 branch [*], but we forgot to fix it in 1.6 branch. > Your patch should be OK. Merged -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Za

Re: bgp proto bug with add paths in bird 1.6.3

2017-03-09 Thread Ondrej Zajicek
On Thu, Mar 09, 2017 at 02:20:28PM +0200, Lennert Buytenhek wrote: > On Mon, Mar 06, 2017 at 07:41:44PM +0200, Lennert Buytenhek wrote: > > > Hi! > > > > bgp_init() in proto/bgp/bgp.c does: > > > > P->accept_ra_types = c->secondary ? RA_ACCEPTED : RA_OPTIMAL; > > > > and then bgp_rx_open() in

Re: bgp proto bug with add paths in bird 1.6.3

2017-03-09 Thread Lennert Buytenhek
On Mon, Mar 06, 2017 at 07:41:44PM +0200, Lennert Buytenhek wrote: > Hi! > > bgp_init() in proto/bgp/bgp.c does: > > P->accept_ra_types = c->secondary ? RA_ACCEPTED : RA_OPTIMAL; > > and then bgp_rx_open() in proto/bgp/packets.c does: > > if (p->add_path_tx) > p->p.accept_ra_types = RA

bgp proto bug with add paths in bird 1.6.3

2017-03-06 Thread Lennert Buytenhek
Hi! bgp_init() in proto/bgp/bgp.c does: P->accept_ra_types = c->secondary ? RA_ACCEPTED : RA_OPTIMAL; and then bgp_rx_open() in proto/bgp/packets.c does: if (p->add_path_tx) p->p.accept_ra_types = RA_ANY; As bgp_init() seems to only be called at configuration time, this means that if y