RE: BGP channel add/remove

2018-06-27 Thread Arvin Gan
Hi Ondrej, It's great, thanks. Thanks Arvin -Original Message- From: Ondrej Zajicek Sent: Wednesday, June 27, 2018 6:53 PM To: Arvin Gan Cc: bird-users@network.cz Subject: Re: BGP channel add/remove On Tue, Jun 26, 2018 at 10:43:59AM +, Arvin Gan wrote: > H

Re: BGP channel add/remove

2018-06-27 Thread Ondrej Zajicek
On Tue, Jun 26, 2018 at 01:28:08PM +0200, Martin Mares wrote: > Hi, > > > Perhaps we should trigger restart when BGP channels are added/removed > > and keep current behavior for 'configure soft'. > > yes, please. "configure" was always intended to switch to a new > configuration, even in cases w

Re: BGP channel add/remove

2018-06-27 Thread Ondrej Zajicek
On Tue, Jun 26, 2018 at 10:43:59AM +, Arvin Gan wrote: > Hi Ondrej, >Thanks for your response. >As my code investigated, the function proto_configure_channel() always > return value "1" , that mean the same is true in function bgp_reconfigure(), > line 917 of proto.c will ignore

Re: BGP channel add/remove

2018-06-27 Thread Ondrej Zajicek
On Mon, Jun 25, 2018 at 07:23:09AM +, Arvin Gan wrote: > Hi All, > After investigate the codes for command "configure", found that when > delete/add channel, the function proto_configure_channel() always return > value "1" , that mean the same is true in function bgp_reconfigure(), l

Re: BGP channel add/remove

2018-06-26 Thread Martin Mares
Hi, > Perhaps we should trigger restart when BGP channels are added/removed > and keep current behavior for 'configure soft'. yes, please. "configure" was always intended to switch to a new configuration, even in cases when it requires protocol restarts. Martin

RE: BGP channel add/remove

2018-06-26 Thread Arvin Gan
quot; ? Thanks Arvin -Original Message- From: Ondrej Zajicek Sent: Tuesday, June 26, 2018 6:22 PM To: Arvin Gan Cc: bird-users@network.cz Subject: Re: BGP channel add/remove On Fri, Jun 22, 2018 at 09:23:02AM +, Arvin Gan wrote: > Hi All, > I am using Bird 2.0.2 version, I create a BGP

Re: BGP channel add/remove

2018-06-26 Thread Ondrej Zajicek
On Fri, Jun 22, 2018 at 09:23:02AM +, Arvin Gan wrote: > Hi All, > I am using Bird 2.0.2 version, I create a BGP instance with one channel IPV4, > that all work normally. Then I modified configuration file and add new > channel IPV6, and using command "configure" under birdc , found the new

RE: BGP channel add/remove

2018-06-25 Thread Arvin Gan
Hi All, After investigate the codes for command "configure", found that when delete/add channel, the function proto_configure_channel() always return value "1" , that mean the same is true in function bgp_reconfigure(), line 917 of proto.c will ignore the change(add/delete channel)..