Re: BGP origin attribute

2018-06-01 Thread Ondrej Zajicek
y matter. > And on Juniper side, all redistributed route are IGP :P > Which is probably smart, since BGP origin attribute is an oldie created > for compatibility with EGP, and that should have since been killed a long > time ago, so everything as IGP makes sense (to basically remove origin

Re: BGP origin attribute

2018-06-01 Thread Ondrej Zajicek
On Fri, Jun 01, 2018 at 09:39:04AM +0200, Olivier Benghozi wrote: > But as a mandatory attribute, how can it be conceptually allowed to remove > this attribute between BGP and BGP ? Most attributes can be defined and undefined in configurable filters, regardless of their meaning. After export fil

Re: BGP origin attribute

2018-06-01 Thread Olivier Benghozi
But as a mandatory attribute, how can it be conceptually allowed to remove this attribute between BGP and BGP ? > Le 31 mai 2018 à 16:10, Ondrej Zajicek a écrit : > > If the route is from BGP but bgp_origin attribute was removed by filters -> > use ORIGIN_INCOMPLETE.

Re: BGP origin attribute

2018-06-01 Thread Olivier Benghozi
And on Juniper side, all redistributed route are IGP :P Which is probably smart, since BGP origin attribute is an oldie created for compatibility with EGP, and that should have since been killed a long time ago, so everything as IGP makes sense (to basically remove origin from the best route

RE: BGP origin attribute

2018-05-31 Thread Arvin Gan
from Cisco is all redistributed route are INCOMPLETE. What's your opinion ? Thanks Arvin -Original Message- From: Ondrej Zajicek Sent: Thursday, May 31, 2018 10:11 PM To: Arvin Gan Cc: bird-users@network.cz Subject: Re: BGP origin attribute On Thu, May 31, 2018 at 03:14:40AM

Re: BGP origin attribute

2018-05-31 Thread Ondrej Zajicek
On Thu, May 31, 2018 at 03:14:40AM +, Arvin Gan wrote: > Hi All, > I notice the origin attribute in function bgp_update_attrs , if route > source is BGP, I think it should set as ORIGIN_IGP, not INCOMPLETE, > according to RFC or Cisco device . It seems there is mistake on Line 1443 in > a

BGP origin attribute

2018-05-30 Thread Arvin Gan
Hi All, I notice the origin attribute in function bgp_update_attrs , if route source is BGP, I think it should set as ORIGIN_IGP, not INCOMPLETE, according to RFC or Cisco device . It seems there is mistake on Line 1443 in attrs.c . Line 1443: bgp_set_attr_u32(&attrs, pool, BA_ORIGIN, 0, src