Re: [RESEND PATCH v3] Babel: allow choosing link quality estimation algorithm

2023-11-10 Thread Toke Høiland-Jørgensen via Bird-users
Nick Cao writes: > The presets are still handled, in babel_iface_finish of > proto/babel/config.Y. Ah, right, I was misreading that part of your patch, sorry about that. Looks like it is, indeed, doing the right thing wrt the old keywords, so no objections to merging this :) Acked-by: Toke Høi

Re: [RESEND PATCH v3] Babel: allow choosing link quality estimation algorithm

2023-11-09 Thread Nick Cao via Bird-users
The presets are still handled, in babel_iface_finish of proto/babel/config.Y. On 11/9/23 05:25, Toke Høiland-Jørgensen wrote: Nick Cao via Bird-users writes: Resend of the patch in http://trubka.network.cz/pipermail/bird-users/2023-June/017058.html ETX link quality estimation algorithm is

Re: [RESEND PATCH v3] Babel: allow choosing link quality estimation algorithm

2023-11-09 Thread Ondrej Zajicek via Bird-users
On Thu, Nov 09, 2023 at 11:25:10AM +0100, Toke Høiland-Jørgensen via Bird-users wrote: > Nick Cao via Bird-users writes: > > Sorry for missing this earlier, but it looks like with your patch bird > will no longer honour the "wires" or "wireless" setting at all? Which > will break old configs, so

Re: [RESEND PATCH v3] Babel: allow choosing link quality estimation algorithm

2023-11-09 Thread Toke Høiland-Jørgensen via Bird-users
Nick Cao via Bird-users writes: > Resend of the patch in > http://trubka.network.cz/pipermail/bird-users/2023-June/017058.html > > ETX link quality estimation algorithm is useful for link types other than > wireless, > especially when using babel with tunnels where packet losses do occur. > ---

Re: Babel RTT mechanism [Was: [RESEND PATCH v3] Babel: allow choosing link quality estimation] algorithm]

2023-11-08 Thread Juliusz Chroboczek
>> And babeld the reference implementation also allows enabling link quality >> estimation and the RTT extension at the same time, matching the current >> behavior of bird. Exactly right. > Considering that ETX estimates number of retransmissions, then for > algorithm that takes into account both

Re: Babel RTT mechanism [Was: [RESEND PATCH v3] Babel: allow choosing link quality estimation] algorithm]

2023-11-08 Thread Ondrej Zajicek
On Wed, Nov 08, 2023 at 11:56:32AM -0500, Nick Cao wrote: > I think it is the intended design. Link quality is about packet losses, > while RTT is about, well, RTT, they cover different characteristics of the > link, which should all be taken into account for metric calculation. RTT has two source

Re: Babel RTT mechanism [Was: [RESEND PATCH v3] Babel: allow choosing link quality estimation] algorithm]

2023-11-08 Thread Nick Cao via Bird-users
I think it is the intended design. Link quality is about packet losses, while RTT is about, well, RTT, they cover different characteristics of the link, which should all be taken into account for metric calculation. And babeld the reference implementation also allows enabling link quality estima

Babel RTT mechanism [Was: [RESEND PATCH v3] Babel: allow choosing link quality estimation] algorithm]

2023-11-08 Thread Ondrej Zajicek
On Sat, Oct 28, 2023 at 09:24:56PM -0400, Nick Cao via Bird-users wrote: > Resend of the patch in > http://trubka.network.cz/pipermail/bird-users/2023-June/017058.html > > ETX link quality estimation algorithm is useful for link types other than > wireless, > especially when using babel with tun

[RESEND PATCH v3] Babel: allow choosing link quality estimation algorithm

2023-10-28 Thread Nick Cao via Bird-users
Resend of the patch in http://trubka.network.cz/pipermail/bird-users/2023-June/017058.html ETX link quality estimation algorithm is useful for link types other than wireless, especially when using babel with tunnels where packet losses do occur. --- doc/bird.sgml| 10 ++ proto/b