Hi BIRD-Community,
I wanted to bring this patch back into focus. We run a non-commercial
WISP-network with Babel and switched to BIRD due to limitations in
babeld. While BIRD works great, we urgently need this patch for better
route filtering flexibility.
It’d be great to see this upstream to
On Sat, Feb 11, 2023 at 02:02:05PM +0100, d...@darkboxed.org wrote:
> Hi Maria,
>
> On Mon, Feb 06, 2023 at 02:19:53PM +0100, Maria Matejka wrote:
> > Picking up this, hoping that it is still relevant.
>
> Yes, absolutely :)
>
> > You can do this as the import/export limits in BGP do exactly thi
And you should also be aware that in BIRD 3, you never get rt_notify while
calling rte_update(); route updates are always asynchronous and you get them
always in a clean context.
Interesting. I'll have to look at that. Speaking of bird v3, is it
intentional that the branch for that isn't publ
HI,
On Sat, Feb 11, 2023 at 02:22:13PM +0100, Maria Matejka wrote:
> > I'm still trying to find a convincing argument for why the bad case can
> > never happen though. Can you think of a codepath that calls rt_notify with
> > one of our own routes outside of us calling into rte_update*? I'm having
Hello!
I'm still trying to find a convincing argument for why the bad case can
never happen though. Can you think of a codepath that calls rt_notify with
one of our own routes outside of us calling into rte_update*? I'm having a
hard time reading the rt-table code, it just has so many twists and
Hi Maria,
On Mon, Feb 06, 2023 at 02:19:53PM +0100, Maria Matejka wrote:
> Picking up this, hoping that it is still relevant.
Yes, absolutely :)
> You can do this as the import/export limits in BGP do exactly this, yet the
> appropriate function
>
> void proto_schedule_down(struct proto *p, b
Hello!
Picking up this, hoping that it is still relevant.
Is there a way we can easily trigger a protocol restart instead of crashing
all of bird with an assertion here if this does happen against all odds?
Hmm, no, I don't think there's any way that the protocol can signal to
the nest that i
On Tue, Jan 31, 2023 at 07:49:03PM +0100, d...@darkboxed.org wrote:
> > > Couple of comments on the code below:
> > >
> > > > Changes in v3:
> > > > - Subsume FIB_RESTART v2 patch: instead of restarting FIB iteration
> > > >we keep lists of actions to perform after FIB iteration is finished.
Hi Ondrej,
On Tue, Jan 31, 2023 at 06:35:27PM +0100, Ondrej Zajicek wrote:
> There are some corner cases where the behavior may be different - e.g.,
> if one has Babel and BGP with add-path enabled connected to one table,
> then all Babel routes would be propagated with BGP. Or if you have a pipe
On Tue, Jan 31, 2023 at 12:38:25PM +0100, Toke Høiland-Jørgensen via Bird-users
wrote:
> Daniel Gröber writes:
> > This allows for filtering routes from specific interfaces and
> > neighbours. With the current internal route selection proto babel exports
> > only up to one route and an admin cann
Daniel Gröber writes:
> Hi Toke,
>
> Thanks for the comprehensive review! See below.
>
> On Tue, Jan 31, 2023 at 12:38:25PM +0100, Toke Høiland-Jørgensen wrote:
>> Daniel Gröber writes:
>> > This appears to not actually be a breaking change as route announcement was
>> > already based on which r
Hi Toke,
Thanks for the comprehensive review! See below.
On Tue, Jan 31, 2023 at 12:38:25PM +0100, Toke Høiland-Jørgensen wrote:
> Daniel Gröber writes:
> > This appears to not actually be a breaking change as route announcement was
> > already based on which routes bird would send back to babel
Daniel Gröber writes:
> This allows for filtering routes from specific interfaces and
> neighbours. With the current internal route selection proto babel exports
> only up to one route and an admin cannot do fine-grained filtering.
>
> To fix this we rip out the internal route selection entirely
This allows for filtering routes from specific interfaces and
neighbours. With the current internal route selection proto babel exports
only up to one route and an admin cannot do fine-grained filtering.
To fix this we rip out the internal route selection entirely and put them
all into the bird's
14 matches
Mail list logo
