Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Jan Matejka
>> (2) make sure that SADR routes and non-SADR routes can coexist in the >> same routing table. > > Is that something that can be fixed in BIRD? Isn't it just a kernel > problem? Kernel may be fixed once. Or you may have two kernel protocols mapping the BIRD's table to one kernel table with SADR a

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Toke Høiland-Jørgensen
Dean writes: > On 03/07/2017 09:51 PM, Toke Høiland-Jørgensen wrote: >> Dean writes: >> >>> On 03/07/2017 09:23 PM, Toke Høiland-Jørgensen wrote: >>> >>> Basically, I want to do the opposite: We are going to have several >>> (well, at least two) protocols that understand source-specific rout

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Dean
On 03/07/2017 09:51 PM, Toke Høiland-Jørgensen wrote: Dean writes: On 03/07/2017 09:23 PM, Toke Høiland-Jørgensen wrote: Basically, I want to do the opposite: We are going to have several (well, at least two) protocols that understand source-specific routing, so the nest data structures

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Toke Høiland-Jørgensen
Dean writes: > On 03/07/2017 09:23 PM, Toke Høiland-Jørgensen wrote: > > Basically, I want to do the opposite: We are going to have several > (well, at least two) protocols that understand source-specific routing, > so the nest data structures should work with both. And since Babel at > l

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Dean
On 03/07/2017 09:23 PM, Toke Høiland-Jørgensen wrote: Basically, I want to do the opposite: We are going to have several (well, at least two) protocols that understand source-specific routing, so the nest data structures should work with both. And since Babel at least is perfectly happy to mix s

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Toke Høiland-Jørgensen
Dean writes: > On 03/07/2017 01:17 PM, Toke Høiland-Jørgensen wrote: >> Dean Luga writes: >> >>> That is correct, it will not be compatible with other OSPF implementations. >>> >>> From what I've searched, there is no standard for supporting SADR in >>> OSPF, only some IETF drafts (some of whic

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Dean
On 03/07/2017 01:17 PM, Toke Høiland-Jørgensen wrote: Dean Luga writes: That is correct, it will not be compatible with other OSPF implementations. From what I've searched, there is no standard for supporting SADR in OSPF, only some IETF drafts (some of which expired) that describe the desir

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Toke Høiland-Jørgensen
Dean Luga writes: > That is correct, it will not be compatible with other OSPF implementations. > > From what I've searched, there is no standard for supporting SADR in > OSPF, only some IETF drafts (some of which expired) that describe the > desired behavior. > > One or two of these drafts plan

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Dean Luga
I see, I'll look into it. On 7 Mar 2017 11:49, "Ondrej Zajicek" wrote: > On Tue, Mar 07, 2017 at 12:56:25AM +0100, Dean Luga wrote: > > From: dean > > > > It compiles with the macro SADR_OSPF defined. > > --- > > configure | 13 - > > 1 file changed, 12 insertions(+), 1 deletion(-)

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Dean Luga
That is correct, it will not be compatible with other OSPF implementations. >From what I've searched, there is no standard for supporting SADR in OSPF, only some IETF drafts (some of which expired) that describe the desired behavior. One or two of these drafts plan to use OSPF extended LSAs to su

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Ondrej Zajicek
On Tue, Mar 07, 2017 at 12:56:25AM +0100, Dean Luga wrote: > From: dean > > It compiles with the macro SADR_OSPF defined. > --- > configure | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure Hi The script 'configure' is autogenerated,

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Toke Høiland-Jørgensen
Dean Luga writes: > I used the configure switch since SADR makes changes to the LSAs and > it will slightly impact network traffic even with source 0::/0. If > someone doesn't want that, they can disable it. As in, when you enable SADR all routes announced now carry a SADR? Does that mean bird w

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Dean Luga
I used the configure switch since SADR makes changes to the LSAs and it will slightly impact network traffic even with source 0::/0. If someone doesn't want that, they can disable it. About the name, you are right, it should be changed. On 7 Mar 2017 10:32, "Toke Høiland-Jørgensen" wrote: Dean

Re: [PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-07 Thread Toke Høiland-Jørgensen
Dean Luga writes: > From: dean > > It compiles with the macro SADR_OSPF defined. Quick comment (I'll look over the rest in more detail later): Why is source address routing guarded by a configure switch? Shouldn't Bird be able to understand source-specific routing always, and have the use of th

[PATCH 1/9] Adding configuration option --enable-sadr.

2017-03-06 Thread Dean Luga
From: dean It compiles with the macro SADR_OSPF defined. --- configure | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 09c6acf..ad92c7f 100755 --- a/configure +++ b/configure @@ -704,6 +704,7 @@ enable_debug enable_memcheck enable_c