Re: [PATCH] babel: Add support for dual-stack v4/v6 operation

2017-05-30 Thread Ondrej Zajicek
On Tue, May 30, 2017 at 02:34:17PM +0200, Toke Høiland-Jørgensen wrote: > Ondrej Zajicek writes: > > > I see no reason not to do conditional initialization of FIBs in > > babel_start(). If a channel appears later, it will stay in CS_DOWN until > > protocol restarts (and FIBs are reinitialized), s

Re: [PATCH] babel: Add support for dual-stack v4/v6 operation

2017-05-30 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, May 30, 2017 at 02:04:00PM +0200, Toke Høiland-Jørgensen wrote: >> Ondrej Zajicek writes: >> >> > On Tue, May 30, 2017 at 01:48:10PM +0200, Ondrej Zajicek wrote: >> >> On Tue, May 30, 2017 at 01:37:56PM +0200, Toke Høiland-Jørgensen wrote: >> >> > > Also channel

Re: [PATCH] babel: Add support for dual-stack v4/v6 operation

2017-05-30 Thread Ondrej Zajicek
On Tue, May 30, 2017 at 02:04:00PM +0200, Toke Høiland-Jørgensen wrote: > Ondrej Zajicek writes: > > > On Tue, May 30, 2017 at 01:48:10PM +0200, Ondrej Zajicek wrote: > >> On Tue, May 30, 2017 at 01:37:56PM +0200, Toke Høiland-Jørgensen wrote: > >> > > Also channel_is_active() is called but chann

Re: [PATCH] babel: Add support for dual-stack v4/v6 operation

2017-05-30 Thread Ondrej Zajicek
On Tue, May 30, 2017 at 01:56:24PM +0200, Toke Høiland-Jørgensen wrote: > Ondrej Zajicek writes: > > > On Tue, May 30, 2017 at 01:37:56PM +0200, Toke Høiland-Jørgensen wrote: > >> > Also channel_is_active() is called but channel may not even exist? > >> > >> Ah, proto_configure_channel can leave

Re: [PATCH] babel: Add support for dual-stack v4/v6 operation

2017-05-30 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, May 30, 2017 at 01:48:10PM +0200, Ondrej Zajicek wrote: >> On Tue, May 30, 2017 at 01:37:56PM +0200, Toke Høiland-Jørgensen wrote: >> > > Also channel_is_active() is called but channel may not even exist? >> > >> > Ah, proto_configure_channel can leave the channe

Re: [PATCH] babel: Add support for dual-stack v4/v6 operation

2017-05-30 Thread Ondrej Zajicek
On Tue, May 30, 2017 at 01:48:10PM +0200, Ondrej Zajicek wrote: > On Tue, May 30, 2017 at 01:37:56PM +0200, Toke Høiland-Jørgensen wrote: > > > Also channel_is_active() is called but channel may not even exist? > > > > Ah, proto_configure_channel can leave the channel var entirely unset? > > Yes,

Re: [PATCH] babel: Add support for dual-stack v4/v6 operation

2017-05-30 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, May 30, 2017 at 01:37:56PM +0200, Toke Høiland-Jørgensen wrote: >> > Also channel_is_active() is called but channel may not even exist? >> >> Ah, proto_configure_channel can leave the channel var entirely unset? > > Yes, it could add/remove/reconfigure the channe

Re: [PATCH] babel: Add support for dual-stack v4/v6 operation

2017-05-30 Thread Ondrej Zajicek
On Tue, May 30, 2017 at 01:37:56PM +0200, Toke Høiland-Jørgensen wrote: > > Also channel_is_active() is called but channel may not even exist? > > Ah, proto_configure_channel can leave the channel var entirely unset? Yes, it could add/remove/reconfigure the channel, based on whether there is or i

Re: [PATCH] babel: Add support for dual-stack v4/v6 operation

2017-05-30 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Mon, May 29, 2017 at 10:24:57PM +0200, Toke Høiland-Jørgensen wrote: >> This adds support for dual-stack v4/v6 operation to the Babel protocol. >> Routing >> messages will be exchanged over IPv6, but IPv4 routes can be carried in the >> messages being exchanged. This

Re: [PATCH] babel: Add support for dual-stack v4/v6 operation

2017-05-30 Thread Ondrej Zajicek
On Mon, May 29, 2017 at 10:24:57PM +0200, Toke Høiland-Jørgensen wrote: > This adds support for dual-stack v4/v6 operation to the Babel protocol. > Routing > messages will be exchanged over IPv6, but IPv4 routes can be carried in the > messages being exchanged. This matches how the reference Babel

[PATCH] babel: Add support for dual-stack v4/v6 operation

2017-05-29 Thread Toke Høiland-Jørgensen
This adds support for dual-stack v4/v6 operation to the Babel protocol. Routing messages will be exchanged over IPv6, but IPv4 routes can be carried in the messages being exchanged. This matches how the reference Babel implementation (babeld) works. The nexthop address for v4 can be configured per