Re: [PATCH] Nest: Read Babel metric as IGP metric

2020-12-28 Thread Ondrej Zajicek
On Mon, Dec 28, 2020 at 05:05:07PM -0800, James Lu wrote: > Hello, > > Can someone take a look at this? It's a pretty simple patch but a patch > nonetheless, so it'd be great if this was fixed upstream. Hello Thanks, merged [*]. Sorry, forgot about that. [*] https://gitlab.nic.cz/labs/bird/-/c

Re: [PATCH] Nest: Read Babel metric as IGP metric

2020-12-28 Thread James Lu
u Date: Sun, 16 Aug 2020 13:24:46 -0700 Subject: [PATCH] Nest: Read Babel metric as IGP metric --- nest/rt-table.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/nest/rt-table.c b/nest/rt-table.c index eff25e5c..504deece 100644 --- a/nest/rt-table.c +++ b/nest/rt-table.c @@ -2873,6 +28

Re: [PATCH] Nest: Read Babel metric as IGP metric

2020-08-18 Thread Toke Høiland-Jørgensen
James Lu writes: > Ah, this isn't for anything too serious. It's just a setup for dn42 I'm > testing out right now. Right, okay, fair enough; was just curious :) -Toke

Re: [PATCH] Nest: Read Babel metric as IGP metric

2020-08-17 Thread James Lu
Ah, this isn't for anything too serious. It's just a setup for dn42 I'm testing out right now. Best, James On 2020-08-17 1:37 a.m., Toke Høiland-Jørgensen wrote: > James Lu writes: > >> Hi all, >> >> When testing Babel with Bird 2.0.7, I noticed that unlike OSPF, Babel >> metrics are not read a

Re: [PATCH] Nest: Read Babel metric as IGP metric

2020-08-17 Thread Toke Høiland-Jørgensen
James Lu writes: > Hi all, > > When testing Babel with Bird 2.0.7, I noticed that unlike OSPF, Babel > metrics are not read as an IGP metric for BGP purposes. I've attached a > simple patch that adds this support - it seems to do the trick in my > local testing. Yeah, this seems reasonable! Ack

Re: [PATCH] Nest: Read Babel metric as IGP metric

2020-08-16 Thread Skyler Mäntysaari
Ah, I seem to be corrected. Never mind me then. On 17/08/2020 0.18, James Lu wrote: I'm honestly not too sure. AFAICT, the repo[1][2] points to the mailing list as the preferred point of contact. [1]: https://gitlab.nic.cz/labs/bird/-/blob/master/README#L65-72 [2]: https://gitlab.nic.cz/labs/bi

Re: [PATCH] Nest: Read Babel metric as IGP metric

2020-08-16 Thread James Lu
I'm honestly not too sure. AFAICT, the repo[1][2] points to the mailing list as the preferred point of contact. [1]: https://gitlab.nic.cz/labs/bird/-/blob/master/README#L65-72 [2]: https://gitlab.nic.cz/labs/bird/-/merge_requests/24#note_73422 On 2020-08-16 2:10 p.m., Skyler Mäntysaari wrote: >

Re: [PATCH] Nest: Read Babel metric as IGP metric

2020-08-16 Thread Skyler Mäntysaari
Shouldn't that be done in Gitlab / Source Code repo? On 16/08/2020 23.58, James Lu wrote: Hi all, When testing Babel with Bird 2.0.7, I noticed that unlike OSPF, Babel metrics are not read as an IGP metric for BGP purposes. I've attached a simple patch that adds this support - it seems to do th

[PATCH] Nest: Read Babel metric as IGP metric

2020-08-16 Thread James Lu
6596 Mon Sep 17 00:00:00 2001 From: James Lu Date: Sun, 16 Aug 2020 13:24:46 -0700 Subject: [PATCH] Nest: Read Babel metric as IGP metric --- nest/rt-table.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/nest/rt-table.c b/nest/rt-table.c index eff25e5c..504deece 100644 --- a/nest/rt