Re: [PATCH] BGP: Add support for BGP hostname capability

2021-02-05 Thread Vincent Bernat
❦ 3 février 2021 23:37 +01, Ondrej Zajicek: > 1) Hostname has similar role like router id. It seems to me that there > should be global hostname config property, like config->router_id, > initialized like router_id in global_commit(). Done. Use `hostname "bla"` > 2) Consequently, there should

Re: [PATCH] BGP: Add support for BGP hostname capability

2021-02-03 Thread Ondrej Zajicek
On Wed, Feb 03, 2021 at 07:19:50PM +0100, Vincent Bernat wrote: > This is an implementation of draft-walton-bgp-hostname-capability-02. > It's implemented since quite some time for FRR and in datacenter, this > gives a nice output to avoid using IP addresses. > > Currently, it is always enabled. T

Re: [PATCH] BGP: Add support for BGP hostname capability

2021-02-03 Thread Vincent Bernat
❦ 3 février 2021 21:27 +01, Job Snijders: > I recommend adjusting the patch in such a way that the capability is > only exchanged with specific neighbors where the capability has been > explicitly enabled through neighbor/group specific configuration. Yes, I'll do that. I am also OK with the pa

Re: [PATCH] BGP: Add support for BGP hostname capability

2021-02-03 Thread Job Snijders
Dear Vincent, Thank you for your contribution, running code always is an excellent way to move specifications for the purpose of interopability forward. I'd like to comment on my favorite topic... *** DEFAULTS :-) On Wed Feb 3 19:19:50 CET 202, you wrote: > > However, maybe the capability s

[PATCH] BGP: Add support for BGP hostname capability

2021-02-03 Thread Vincent Bernat
This is an implementation of draft-walton-bgp-hostname-capability-02. It's implemented since quite some time for FRR and in datacenter, this gives a nice output to avoid using IP addresses. Currently, it is always enabled. The hostname is retrieved from uname(2) and not configurable. The domain na