Re: [PATCH] Fix Bird/Bird6 wrong LSA collisions detection

2018-11-08 Thread Mikkelsen, Asbjorn
ndrej Zajicek" wrote: On Tue, Nov 06, 2018 at 04:15:34PM +0100, Ondrej Zajicek wrote: > On Tue, Nov 06, 2018 at 08:53:35AM +0000, Mikkelsen, Asbjorn wrote: > > Bird/Bird6 can wrongly report wrong LSA collisions and stop working. A route > > fib can in certain cas

Re: Re: [PATCH] Fix Bird/Bird6 wrong LSA collisions detection

2018-11-08 Thread Mikkelsen, Asbjorn
Thanks for looking at the patch, Ondrej. 1. Discussing it with an SME here, this seems a fair description of what is happening. 2. I think that part of the comment might be inaccurate now, since as you say, the NULL case is already covered above it. 3. They could be removed. During the debuggi

[PATCH] Fix Bird/Bird6 wrong LSA collisions detection

2018-11-06 Thread Mikkelsen, Asbjorn
Bird/Bird6 can wrongly report wrong LSA collisions and stop working. A route fib can in certain cases be released (believing nobody are using them) and still be used (but not dereferenced). A PR can be found here: https://github.com/BIRD/bird/pull/3