Re: [PATCH RFC 2/2] babel: Add HMAC support

2018-07-18 Thread Martin Mares
Hi, > Also note that even getrandom() is relatively recent. We probably should > handle somehow the case that none of these is available. on Linux, it is probably safer to read from /dev/urandom. Martin

Re: [PATCH RFC 2/2] babel: Add HMAC support

2018-07-14 Thread Martin Mares
Hi Toke, just a random thought: > + getrandom(n->hmac_nonce, BABEL_HMAC_NONCE_LEN, 0); I think we cannot rely on getrandom() being available on all systems. It probably needs wrapping in sysdep code. Have a nice fortnight -- Martin `MJ' Mares

Re: BGP channel add/remove

2018-06-26 Thread Martin Mares
Hi, > Perhaps we should trigger restart when BGP channels are added/removed > and keep current behavior for 'configure soft'. yes, please. "configure" was always intended to switch to a new configuration, even in cases when it requires protocol restarts. Martin

Re: Request for Comments: Filter behavior on undefined values

2018-01-09 Thread Martin Mares
Hello! > Assuming NOT is NEG [...] Yes. > [...] and conditionals fail for non-true. In Sherlock, we had three-way conditionals: if the condition was undefined, neither the "then" nor "else" branch was executed, but there could be an additional "undefined" branch. In retrospect, this probably wa

Re: Request for Comments: Filter behavior on undefined values

2018-01-09 Thread Martin Mares
Hello! > Variants we thought about when an undefined attribute is to be read: > > 1 the filter fails with an error. > 2 the value is set to default (zero or whatever) and then used > 3 it is propagated as undefined until any comparison/match happens, >then the comparison/match is always fa

Re: IETF-99

2017-07-17 Thread Martin Mares
Hi! > Although i am not an atendee of IETF 99, i am in Praha and i would be > glad to meet with BIRD users atending IETF 99. If there are more > interested people, we could make a common meeting. I am going to be in Prague this week, so if you plan to meet, I will be happy to join.

Re: Structured output

2017-06-21 Thread Martin Mares
Hello, world!\n > Something like libxo support would be pretty cool, > https://github.com/Juniper/libxo > > That'd provide text, XML, JSON, and HTML output. For many applications, text-based formats are too slow. This is the reason why I prefer to base the structured format on CBOR, which is mu

Re: Structured output

2017-06-21 Thread Martin Mares
Hi! > > Would it not be possible to add the ability to request structured data > > back? i.e. receive a response with the data encoded in json, protobuf, or > > even xml. > > +1 Together with David Cepelik, we are experimenting with structured output based on CBOR. You can expect some preliminar

Re: [PATCH] Babel: Fix pointer arithmetic in subtlv parsing

2017-06-14 Thread Martin Mares
Hello, world!\n >for (tlv = (void *) hdr + state->current_tlv_endpos; > - tlv < hdr + TLV_LENGTH(hdr); > + (void *) tlv < (void *) hdr + TLV_LENGTH(hdr); > tlv = NEXT_TLV(tlv)) BTW, is there any reason for doing that pointer arithmetics on void pointers instead of char poi

Re: [Feature request] DHCPv6 protocol

2017-04-01 Thread Martin Mares
Hello! > Then you run into problems. None of the current implementation which I've > tried (ISC, Kea, DHCPKit) doesn't add routes for delegated prefixes into > routing table. This way the delegated prefix is unreachable and end user has > got broken connectivity. Maybe I am missing something, bu

Re: multithreading ospf

2017-03-12 Thread Martin Mares
> Bird is single-threaded. Only when BFD is used, Bird spawns a separate > thread for it as the main internal timer is too slow for BFD. ... still, you have a good chance that Bird will be much faster than Quagga on your workload. Have a nice fortnight -- Martin `

Re: bird vs cisco/quagga

2017-02-27 Thread Martin Mares
Hello! > I'm newbie to bird. Used cisco/quagga before. But filter language of bird > is very nice, so I want to try it. But I have one big misunderstanding. > With other vendors each protocol has it own routing table. So OSPF may work > only with ospf prefixes, BGP with bgp and so on. If we need p

Re: Version 2.0.0pre0

2016-12-08 Thread Martin Mares
Hello, world!\n > I think that we should expand static protocol to allow adding or deleting > routes interactively. There are some problematic behavioral details in > it; e.g., how we should handle interactive removal of a route from > configuration. Should we have two independent sets of routes,

Re: CLI debugging

2016-09-05 Thread Martin Mares
Hello, world!\n > In my opinion, the quotes by "", "{" and "}" is confusing > too. And a comma should be probably quoted too in this case. New > line before available flags is possible but inconsistent. As far as I remember my original intentions years ago, { and } are ambiguous, because they can

Re: Help on customizing BIRD- getting community value

2016-05-26 Thread Martin Mares
Hello! > I am a PhD student at Roma Tre University of Rome, Italy and I am > working on implementation of route server at IXP with BIRD. I want > to have access to community values inside BIRD which are sent by > ASes. Based on received community values I want to customize BIRD > code. > > I foun

Re: OSPF sequence mismatch occurring regularly

2014-11-10 Thread Martin Mares
Hello, world!\n > I find the behavior surprising, as bird in all other situations that I am > aware of does not block on IO operations. It only uses blocking IO when > writing to the log file. Unfortunately, non-blocking operations on plain files are not supported by most operating systems, inclu