Re: memcpy uses value of mls (mpls label stack) instead of address

2024-04-11 Thread Maria Matejka via Bird-users
Hello Ramanathan, On Fri, Apr 12, 2024 at 10:09:34AM +0530, Ramanathan Selvamani wrote: > [...] > > memcpy(mls.stack, &a->nh.label[a->nh.labels - mls.len], mls.len * > sizeof(u32)); > > > Here the "mls.stack" is passed directly instead of its address in memcpy. - `a->nh.label` is of type `u32 [

Re: memcpy uses value of mls (mpls label stack) instead of address

2024-04-11 Thread Ramanathan Selvamani
Hi Team, I am resending the line of code again since the last mail was not showing up correctly. memcpy(mls.stac*k*, &a->nh.label[a->nh.labels - mls.len], mls.len * sizeof(u32)); Thanks. On Fri, 12 Apr 2024 at 09:58, Ramanathan Selvamani wrote: > Hi Team, > > I have tried to use mpls_label_s

memcpy uses value of mls (mpls label stack) instead of address

2024-04-11 Thread Ramanathan Selvamani
Hi Team, I have tried to use mpls_label_stack to keep some meta data for each route. But the values of meta data were not copied correctly. I just found the below code in "rt_next_hop_update_rte" function in rt-table.c memcpy(*mls.**stack*, &a->nh.label[a->nh.labels - mls.len], mls.len * sizeof

babel RTT metric false samples

2024-04-11 Thread Stephanie Wilde-Hobbs via Bird-users
Hi, The babel RTT metric measurements provided by bird appears suspect for my setup. The metric through a tunnel with a latency of about 5ms is shown in babel as 150+ms. Can others replicate this issue? (should be easy to check for other babel users since RTT measurement is on by default in

Re: 2.0 user's guide shows incorrect date format for passwords

2024-04-11 Thread Ondrej Zajicek via Bird-users
On Wed, Mar 27, 2024 at 11:25:12AM +, Pisilä Janne via Bird-users wrote: > Hello, > > The password protocol option section in user's guide 2.0 > https://bird.network.cz/?get_doc&v=20&f=bird-3.html#proto-pass > incorrectly shows date format as dd-mm- when it should be -mm-dd in > BIRD