Re: [PATCH RFC 2/2] babel: Add HMAC support

2018-08-14 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > Hi > > Finally got to finish the review. The code looks OK, comments below. Thank you for the review! The draft was just accepted by the babel working group, so I expect there will be a new version along soon. I'll fix the issues you point out and submit a proper patch o

Re: [PATCH RFC 2/2] babel: Add HMAC support

2018-08-14 Thread Ondrej Zajicek
Hi Finally got to finish the review. The code looks OK, comments below. The getrandom() issue and issue with fixed length of indexes and so on was already mentioned before. I am OK with reasonable fixed upper bound, but the code should be able to handle received shorter ones. I have an issue with

Re: BFD socket bind error upon reboot

2018-08-14 Thread Ondrej Zajicek
On Fri, Aug 10, 2018 at 11:23:56PM +0200, J. Kendzorra wrote: > Hi, > > upon a reboot of a system running BFD I recently noticed BFD breaking > with error "Cannot assign requested address" once the system came back. > Restarting the BFD protocol in question solved the problem. > Hence, apparently

Re: Strange behavior, cannot reach 4th hop

2018-08-14 Thread Ondrej Zajicek
On Fri, Aug 10, 2018 at 10:06:19AM +, TI2015: Kulesza, Dawid wrote: > Hello, > > few days ago I struggled with bird configuration over openvpn. It's > working now. I can see, that every host has proper routes and with birdc > show ospf topology I can see, that every router sees everyone else.

Re: Arista Switch BFD issue - custom port

2018-08-14 Thread Ondrej Zajicek
On Mon, Aug 13, 2018 at 03:14:10PM +0200, Jakub Nowacki wrote: > Hi, > > I'm running BIRD on Arista which allows access to Linux bash. I'm having > issue with running multihop BFD session on it and I believe it's related to > port being already binded. > > > bash-4.3# netstat -tulpen | grep 4784