Re: Increasing the granularity of internal timers in Bird?

2017-06-06 Thread Gabriel
Il 2017-06-05 18:53 Toke Høiland-Jørgensen ha scritto: Hey I have been looking at changing the internal timers in Bird to operate at millisecond granularity instead of the current one-second steps. I have two motivations for this: - The Babel protocol specifies time in 10ms increments, and I wa

[PATCH v2] babel: Implement IPv6 prefix compression on outgoing updates

2017-06-06 Thread Toke Høiland-Jørgensen
Previously, the Babel protocol would never use prefix compression on outgoing updates (but would parse it on incoming ones). This adds compression of IPv6 addresses of outgoing updates. The compression only works to the extent that the FIB is walked in lexicographic order; i.e. a prefix is only co

Re: [PATCH 1/3] lib: Add ip6_common_octets function

2017-06-06 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, Jun 06, 2017 at 01:00:38PM +0200, Toke Høiland-Jørgensen wrote: >> Christian Tacke writes: >> >> > Hi, >> > >> > just out of curiosity: >> > >> > On Mon, Jun 05, 2017 at 23:49:52 +0200, Toke Høiland-Jørgensen wrote: >> > [...] >> >> +int >> >> +ip6_common_octets

Re: [PATCH 1/3] lib: Add ip6_common_octets function

2017-06-06 Thread Ondrej Zajicek
On Tue, Jun 06, 2017 at 01:00:38PM +0200, Toke Høiland-Jørgensen wrote: > Christian Tacke writes: > > > Hi, > > > > just out of curiosity: > > > > On Mon, Jun 05, 2017 at 23:49:52 +0200, Toke Høiland-Jørgensen wrote: > > [...] > >> +int > >> +ip6_common_octets(ip6_addr a, ip6_addr b) > >> +{ > >>

Re: [PATCH 0/3] babel: Add compression and support for subtlvs

2017-06-06 Thread Ondrej Zajicek
On Tue, Jun 06, 2017 at 12:42:23PM +0200, Toke Høiland-Jørgensen wrote: > Ondrej Zajicek writes: > > > On Mon, Jun 05, 2017 at 11:49:51PM +0200, Toke Høiland-Jørgensen wrote: > >> This patch series adds compression of outgoing IPv6 prefixes to the > >> Babel protocol, and also adds support to the

Re: [PATCH 1/3] lib: Add ip6_common_octets function

2017-06-06 Thread Toke Høiland-Jørgensen
Christian Tacke writes: > Hi, > > just out of curiosity: > > On Mon, Jun 05, 2017 at 23:49:52 +0200, Toke Høiland-Jørgensen wrote: > [...] >> +int >> +ip6_common_octets(ip6_addr a, ip6_addr b) >> +{ >> + int i, j, common = 0; > [...] > > Why aren't you using an unsigned int here? No particular

Re: [PATCH 0/3] babel: Add compression and support for subtlvs

2017-06-06 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Mon, Jun 05, 2017 at 11:49:51PM +0200, Toke Høiland-Jørgensen wrote: >> This patch series adds compression of outgoing IPv6 prefixes to the >> Babel protocol, and also adds support to the parser for parsing subtlvs >> as per RFC6126 bis (see >> https://tools.ietf.org/h

Re: [PATCH 0/3] babel: Add compression and support for subtlvs

2017-06-06 Thread Ondrej Zajicek
On Mon, Jun 05, 2017 at 11:49:51PM +0200, Toke Høiland-Jørgensen wrote: > This patch series adds compression of outgoing IPv6 prefixes to the > Babel protocol, and also adds support to the parser for parsing subtlvs > as per RFC6126 bis (see > https://tools.ietf.org/html/draft-ietf-babel-rfc6126bis

Re: Increasing the granularity of internal timers in Bird?

2017-06-06 Thread Ondrej Zajicek
On Mon, Jun 05, 2017 at 11:19:15PM +0200, Toke Høiland-Jørgensen wrote: > > It is a recent branch that replaces current timers with microsecond > > timers (already used in BFD). You could just swap bird_clock_t, timer > > and tm_*() functions with btime, timer2 and tm2_*() functions (with > > updat

Re: [PATCH 1/3] lib: Add ip6_common_octets function

2017-06-06 Thread Christian Tacke
Hi, just out of curiosity: On Mon, Jun 05, 2017 at 23:49:52 +0200, Toke Høiland-Jørgensen wrote: [...] > +int > +ip6_common_octets(ip6_addr a, ip6_addr b) > +{ > + int i, j, common = 0; [...] Why aren't you using an unsigned int here? Cheers Christian -- www.cosmokey.com