Re: [Babel-users] Version 1.6.0

2016-05-01 Thread Toke Høiland-Jørgensen
Juliusz Chroboczek writes: >> Hmm, maybe this should be spelled out somewhere? > > Could you please clarify what exactly needs to be spelled out? I have > the impression that the meaning of AE 0 is spelled out pretty clearly > in all three pleaces where it is allowed. The one missing bit is > Upd

Re: [Babel-users] Version 1.6.0

2016-05-01 Thread Juliusz Chroboczek
>> It is not allowed in any other place -- in other places, RFC 6126 says >> that AE MUST NOT be 0. (There's an omission in Section 4.4.9, where it >> only says in what case AE MAY be 0; the implication is that it MUST >> NOT be 0 in other cases.) > Hmm, maybe this should be spelled out somewhere?

Re: Babel in Bird 1.6.0

2016-05-01 Thread Toke Høiland-Jørgensen
Vasiliy Tolstov writes: > Do you have plans in near feature create ipv4 support?in this case I > can drop bird and use only bird6 for ipv4/ipv6 routes inside my > network. Would love to, but that requires dual-stack support in Bird core. AFAIK there are plans to support this eventually, but Ondr

Re: Babel in Bird 1.6.0

2016-05-01 Thread Vasiliy Tolstov
Do you have plans in near feature create ipv4 support?in this case I can drop bird and use only bird6 for ipv4/ipv6 routes inside my network. 1 Май 2016 г. 16:14 пользователь "Toke Høiland-Jørgensen" написал: > Ondrej Zajicek writes: > > >> Right, yeah, the overflow check is done on the specifie

Re: Version 1.6.0

2016-05-01 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Sun, May 01, 2016 at 03:32:58PM +0200, Toke Høiland-Jørgensen wrote: >> Ondrej Zajicek writes: >> >> > - in some cases (e.g. babel_handle_route_request()), check for plen == 0 >> >or check if prefix is IPA_NONE is used where check for AE 0 should be >> >used

Re: [Babel-users] Version 1.6.0

2016-05-01 Thread Toke Høiland-Jørgensen
Juliusz Chroboczek writes: >> If this is not the case, I think the RFC needs to specify what, >> exactly, is meant by a "wildcard address". I've always thought of >> ::/0 as the wildcard address; and doesn't "default route" also mean >> "wildcard route"? > > Wow, no. Yes, feel free to marvel at

Re: Version 1.6.0

2016-05-01 Thread Ondrej Zajicek
On Sun, May 01, 2016 at 03:32:58PM +0200, Toke Høiland-Jørgensen wrote: > Ondrej Zajicek writes: > > > - in some cases (e.g. babel_handle_route_request()), check for plen == 0 > >or check if prefix is IPA_NONE is used where check for AE 0 should be > >used instead. Note that these are tw

Re: [Babel-users] Version 1.6.0

2016-05-01 Thread Juliusz Chroboczek
> If this is not the case, I think the RFC needs to specify what, exactly, > is meant by a "wildcard address". I've always thought of ::/0 as the > wildcard address; and doesn't "default route" also mean "wildcard > route"? Wow, no. The main purpose of a routing protocol is to carry prefixes. No

Re: Version 1.6.0

2016-05-01 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > Some comments to my changes. I originally thought that i would just do > some minor formatting changes, but i end with some heavy code changes and > plenty of bugfixes. Hopefully i did not make much more errors. Thanks for the overview. Some comments below. > Some issue

Re: Babel in Bird 1.6.0

2016-05-01 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: >> Right, yeah, the overflow check is done on the specified values not >> their centisecond equivalents. Oops. > > IMHO the reasonable way would be to keep such values (intervals) > internally in Babel native time units (centiseconds) and only convert > to BIRD units when a