Re: Babel in Bird 1.6.0

2016-04-30 Thread Ondrej Zajicek
On Sat, Apr 30, 2016 at 03:15:52PM +0200, Toke Høiland-Jørgensen wrote: > > === Hello interval range checking === > > > > The hello interval cannot be set below 1 second: the parser seems to > > expect an integer. The packet format encodes intervals in centiseconds, > > so it would make sense to a

Re: Version 1.6.0

2016-04-30 Thread Ondrej Zajicek
On Sat, Apr 30, 2016 at 01:20:14AM +0200, Toke Høiland-Jørgensen wrote: > >Hi > > > >I would like to thank Toke Høiland-Jørgensen for the Babel protocol > >implementation, which was finally merged despite my tardy code reviews. > > Yay, awesome! You're very welcome, and congratulations on the rele

Re: Version 1.6.0

2016-04-30 Thread Thomas King
Hi all, Am 2016-04-29 18:35, schrieb Ondrej Filip: Dear Bird users, the long expected version is out: Version 1.6.0 (2016-04-29) o Major RIP protocol redesign o New Babel routing protocol o BGP multipath support o KRT: Add support for plenty of kernel route metrics o KRT: Allow more t

Re: Version 1.6.0

2016-04-30 Thread Job Snijders
On Sat, Apr 30, 2016 at 09:19:25PM +0200, Ondrej Zajicek wrote: > On Sat, Apr 30, 2016 at 09:24:12AM +0200, Job Snijders wrote: > > Any hint on the schedule for the next release, which hopefully > > includes mrt dump file rotation? > > I hope we could establish quarterly releases. Is there a way

Re: Babel in Bird 1.6.0

2016-04-30 Thread Juliusz Chroboczek
> Also now it seems to me that even the current code is not valid as it > implicitly assumes that the prefix length is 128 with this flag. > As the spec says 'low-order 8 octets of the advertised prefix' then > if one advertise 2001:DB8:1020:3040:5060:7080::/96, then low-order > 8 octets of this *p

Re: Version 1.6.0

2016-04-30 Thread Ondrej Zajicek
On Sat, Apr 30, 2016 at 09:24:12AM +0200, Job Snijders wrote: > Any hint on the schedule for the next release, which hopefully includes > mrt dump file rotation? I hope we could establish quarterly releases. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.or

Re: Version 1.6.0

2016-04-30 Thread Andrew
It'll be good to run bird under valgrind for testing - I catched some bugs in 1.4.x in that way. 30.04.2016 14:08, Vladimir Lettiev пишет: On Fri, Apr 29, 2016 at 06:35:33PM +0200, Ondrej Filip wrote: Dear Bird users, the long expected version is out: Version 1.6.0 (2016-04-29) o Major RIP

Re: Babel in Bird 1.6.0

2016-04-30 Thread Ondrej Zajicek
On Sat, Apr 30, 2016 at 03:15:52PM +0200, Toke Høiland-Jørgensen wrote: > Baptiste Jonglez writes: > > While I'm not sure what the purpose of this is (a null update with a > null router ID with infinity metric and interval?) it *is* technically > in spec. I think the reason why Bird complains is t

Re: Babel in Bird 1.6.0 (documentation)

2016-04-30 Thread Ondrej Zajicek
On Sat, Apr 30, 2016 at 04:41:35PM +0200, Baptiste Jonglez wrote: > It's not that obvious that you can use import/export functions to filter > routes. This is especially important because the default policy (import all, > export none) is not very useful. > > For instance, the default behaviour of

Re: [Babel-users] Babel in Bird 1.6.0

2016-04-30 Thread Juliusz Chroboczek
> So I was referring to the text stating "the current router-id and seqno > is not used" - does that refer to all retractions or just wildcard ones? RFC 6126 doesn't say. It should be all retractions. > Well, I've always thought about 0x40 as specifying that the router ID be > the 64 bits from t

Re: [Babel-users] Babel in Bird 1.6.0

2016-04-30 Thread Toke Høiland-Jørgensen
Juliusz Chroboczek writes: >> Okay, actually trying to put this into code: Is the intention here that >> a null-router ID update is acceptable only on *wildcard* retractions or >> on *all* retractions? > > In RFC 6126, there's nothing special about a null router-ID: it's just > a router ID. I di

Re: [Babel-users] Babel in Bird 1.6.0

2016-04-30 Thread Juliusz Chroboczek
> Okay, actually trying to put this into code: Is the intention here that > a null-router ID update is acceptable only on *wildcard* retractions or > on *all* retractions? In RFC 6126, there's nothing special about a null router-ID: it's just a router ID. However, for AEs 0 and 1, the address is

Re: [Babel-users] Babel in Bird 1.6.0

2016-04-30 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen writes: >> The plan is to explicitly allow such retractions in RFC 6126-bis, but >> they are clearly not allowed by RFC 6126. > > Hmm, the RFC says this (which I seem to have previously missed): > > If the metric field is hexadecimal, this TLV specifies a > retract

Re: [Babel-users] Babel in Bird 1.6.0

2016-04-30 Thread Juliusz Chroboczek
> Ah, I see. But surely, having an update with AE 0 and the flag set would > not be out of spec either, as long as router ID 0 is not disallowed? That's what I thought too, but Markus disagreed. -- Juliusz

Re: [Babel-users] Babel in Bird 1.6.0

2016-04-30 Thread Toke Høiland-Jørgensen
Juliusz Chroboczek writes: >> Why is babeld setting the 0x40 flag on those updates, though? > > It was supposed to clear the router-id. Recent versions no longer do. Ah, I see. But surely, having an update with AE 0 and the flag set would not be out of spec either, as long as router ID 0 is not

Re: [Babel-users] Babel in Bird 1.6.0

2016-04-30 Thread Juliusz Chroboczek
> Well I would certainly argue that it was allowed; but apparently easy to > miss. Ok. Then please consider it as allowed, as all current implementation parse it fine. > Why is babeld setting the 0x40 flag on those updates, though? It was supposed to clear the router-id. Recent versions no lon

Re: Babel in Bird 1.6.0 (documentation)

2016-04-30 Thread Toke Høiland-Jørgensen
Baptiste Jonglez writes: > On Sat, Apr 30, 2016 at 04:15:46PM +0200, Toke Høiland-Jørgensen wrote: >> Baptiste Jonglez writes: >> >> > Ah, I thought that this "interface" statement was specific to Babel, but >> > it's actually defined for all protocols. The syntax seems fairly complex: >> > >>

Re: [Babel-users] Babel in Bird 1.6.0

2016-04-30 Thread Toke Høiland-Jørgensen
Juliusz Chroboczek writes: >> But those updates seem to set flag 0x40, so that's not "without a router >> ID" is it? > > Yeah, it was meant to clear the router-id. > >>> The plan is to explicitly allow such retractions in RFC 6126-bis, but >>> they are clearly not allowed by RFC 6126. > >> Hmm, t

Re: [Babel-users] Babel in Bird 1.6.0

2016-04-30 Thread Juliusz Chroboczek
> But those updates seem to set flag 0x40, so that's not "without a router > ID" is it? Yeah, it was meant to clear the router-id. >> The plan is to explicitly allow such retractions in RFC 6126-bis, but >> they are clearly not allowed by RFC 6126. > Hmm, the RFC says this (which I seem to have

Re: Babel in Bird 1.6.0 (documentation)

2016-04-30 Thread Baptiste Jonglez
On Sat, Apr 30, 2016 at 04:15:46PM +0200, Toke Høiland-Jørgensen wrote: > Baptiste Jonglez writes: > > > Ah, I thought that this "interface" statement was specific to Babel, but > > it's actually defined for all protocols. The syntax seems fairly complex: > > > > http://bird.network.cz/?get_do

Re: Babel in Bird 1.6.0

2016-04-30 Thread Toke Høiland-Jørgensen
Baptiste Jonglez writes: > Ah, I thought that this "interface" statement was specific to Babel, but > it's actually defined for all protocols. The syntax seems fairly complex: > > http://bird.network.cz/?get_doc&f=bird-3.html#ss3.3 > > IP prefixes are allowed for OSPF, which explains the error

Re: [Babel-users] Babel in Bird 1.6.0

2016-04-30 Thread Toke Høiland-Jørgensen
Juliusz Chroboczek writes: >> I remember running into this. What happens here is that babeld sends an >> update without a preceding router_id TLV, with a wildcard address, but >> flag 0x40 set (meaning "infer the router ID from the address"). >> While I'm not sure what the purpose of this is (a n

Re: [Babel-users] Babel in Bird 1.6.0

2016-04-30 Thread Juliusz Chroboczek
>> The packet format encodes intervals in centiseconds, so it would make >> sense to allow any fractional Hello interval down to 0.01 seconds. > since the internal Bird timers run at a granularity of seconds only > there's not much point in having the ability to configure smaller > values. That's

Re: Babel in Bird 1.6.0

2016-04-30 Thread Baptiste Jonglez
On Sat, Apr 30, 2016 at 03:15:52PM +0200, Toke Høiland-Jørgensen wrote: > > === Configuration === > > > > When the quotes are missing around the interface name, the error message > > is misleading. This configuration: > > > > protocol babel { > > interface eth0; > > } > > > > gives

Re: Babel in Bird 1.6.0

2016-04-30 Thread Toke Høiland-Jørgensen
Baptiste Jonglez writes: > On Sat, Apr 30, 2016 at 01:20:14AM +0200, Toke Høiland-Jørgensen wrote: >> On 29 April 2016 20:24:43 CEST, Ondrej Zajicek >> wrote: >> >I would like to thank Toke Høiland-Jørgensen for the Babel protocol >> >implementation, which was finally merged despite my tardy co

Re: Version 1.6.0

2016-04-30 Thread Mikhail A. Grishin
noc...@msk-ix.ru 29 апреля 2016 г. 19:35:33 GMT+03:00, Ondrej Filip пишет: >Dear Bird users, >the long expected version is out: > >Version 1.6.0 (2016-04-29) > o Major RIP protocol redesign > o New Babel routing protocol > o BGP multipath support > o KRT: Add support for plenty of kernel rout

Babel in Bird 1.6.0

2016-04-30 Thread Baptiste Jonglez
On Sat, Apr 30, 2016 at 01:20:14AM +0200, Toke Høiland-Jørgensen wrote: > On 29 April 2016 20:24:43 CEST, Ondrej Zajicek wrote: > >I would like to thank Toke Høiland-Jørgensen for the Babel protocol > >implementation, which was finally merged despite my tardy code reviews. > > Yay, awesome! You'r

Re: Version 1.6.0

2016-04-30 Thread Vladimir Lettiev
On Fri, Apr 29, 2016 at 06:35:33PM +0200, Ondrej Filip wrote: > Dear Bird users, > the long expected version is out: > > Version 1.6.0 (2016-04-29) > o Major RIP protocol redesign Looks like the same issue with -D_FORTIFY_SOURCE=2 raised again http://bird.network.cz/pipermail/bird-users/20

Re: Version 1.6.0

2016-04-30 Thread Job Snijders
Hi Ondrej, On Fri, Apr 29, 2016 at 06:35:33PM +0200, Ondrej Filip wrote: > Dear Bird users, > the long expected version is out: > > Version 1.6.0 (2016-04-29) > o Major RIP protocol redesign > o New Babel routing protocol > o BGP multipath support > o KRT: Add support for plenty of kernel