Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-06 Thread George Weingart
Lori, Thanks for all your help! George On Tue, Aug 6, 2019 at 5:22 PM Shepherd, Lori wrote: > That should be good to push to the release branch. I will check tomorrow > and keep and eye on the build report but on quick glance it looks correct. > Thank you for all your effort on this. > Cheers >

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-06 Thread Shepherd, Lori
That should be good to push to the release branch. I will check tomorrow and keep and eye on the build report but on quick glance it looks correct. Thank you for all your effort on this. Cheers Get Outlook for Android From: George Weingart

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-06 Thread George Weingart
Hi Lori, I followed all the instructions in http://bioconductor.org/developers/how-to/git/maintain-bioc-only/. See log below. Is there anything that I need to do at this point ? Thanks so much for all your help ! George Weingart PhD Huttenhower Lab Harvard School of Public Health *Log:* Tanias

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-05 Thread Shepherd, Lori
Hi George, No problem at all. We are glad to help and glad you are being so cautious. I am able to see the successful commit/changes on devel (master branch). So that has been successful. You would need to make similar changes to the RELEASE_3_9 branch as your package was failing in both

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-05 Thread George Weingart
Hi Lori, I followed your instructions and went as far as “git push upstream master” Do I need to do the “(Optional) Merge changes to the current release branch” ? As I mentioned, I am being extra careful so I do not damage the repository. Thanks so much for your help !! George Here is the lo

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-05 Thread Shepherd, Lori
So you only have a Bioconductor git repository, not your own github repository to also keep track of changes? Then these instructions are correct: http://bioconductor.org/developers/how-to/git/maintain-bioc-only/ We normal recommend changing the name of the remote from origin to upstream so

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-05 Thread George Weingart
Hi Lori, Here is the display you wanted to see. Tanias-MacBook-Air:banocc georgeweingart$ *git remote -v* origin g...@git.bioconductor.org:packages/banocc (fetch) origin g...@git.bioconductor.org:packages/banocc (push) Tanias-MacBook-Air:banocc georgeweingart$ So what should the next step be

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-05 Thread Shepherd, Lori
Can you please display the results from git remote -v It looks like you may have not setup the remote to point to the Biocondutor repository. # 2 from here: http://bioconductor.org/developers/how-to/git/sync-existing-repositories/ The code below looks like it is pulling and comparing to

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-04 Thread George Weingart
Hi Lori and Bioc-Devel, I followed Lori's instructions but the push is failing - I must be doing something wrong. Here is the log: Can you tell me how to do it right ? Thanks! George Weingart PhD Huttenhower Lab Harvard School of Public Health Tanias-MacBook-Air:banocc georgeweingart$ git check

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-02 Thread Shepherd, Lori
Hello, The package was failing in release and devel. There are two separate branches in Bioconductor. The master branch of a package is always the devel branch of Bioconductor where you pushed "1.9.1". We do see this clean report. http://bioconductor.org/checkResults/devel/bioc-LATEST/bano

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-08-01 Thread George Weingart
Hi Lori, I pushed about two weeks ago the changes that result in a good Build and Check at version 1.9.1 (of Banocc) but I am still getting errors pertaining to Build at release 1.8.0. Did I do something wrong ? Perhaps I did not push correctly ? Can I trouble you to look at it and let me know

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-07-15 Thread George Weingart
Hello Lori, Done ! I removed the two references to c++11 from the package, ran a BUILD and a CHECK and they were clean. Pushed the changes. Below, the log of the push. Let me know what you find in the BiocCheck space pertaining the Sweave error. Thank you ! Best regards, George Weingart PhD

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-07-15 Thread George Weingart
Thanks Lori! Will do. Let me know about BiocCheck. Thanks! George Weingart On Mon, Jul 15, 2019 at 10:26 AM Shepherd, Lori < lori.sheph...@roswellpark.org> wrote: > I can look into the BiocCheck ERROR for future development. It would be > good to figure out why this is happening. But in the m

Re: [Bioc-devel] banocc: Bioconductor BUILD error

2019-07-15 Thread Shepherd, Lori
I can look into the BiocCheck ERROR for future development. It would be good to figure out why this is happening. But in the meantime, if your solution passes R CMD build and R CMD check please continue with pushing to the git.bioconductor.org server as BiocCheck is not run on the nightly bui