Re: [Bioc-devel] Resetting to previous commits

2019-08-14 Thread Pages, Herve
On 8/14/19 10:19, Kasper Daniel Hansen wrote: ... > > Pro-tip: In general, you will be well served not to get too attached to > version numbers. Bump it frequently even without new functionality or bug > fixes and just live with the frequent bumping. +1 for Best Advice Of The Week. -- Hervé Pa

Re: [Bioc-devel] Resetting to previous commits

2019-08-14 Thread Kasper Daniel Hansen
Yes, it will build the most recent version If the previous build failed it will even build the most recent code, even if the code is not bumped. The exception is the following you update package A to version X, build succeeds you commit code to package A, but does not bump the version This wil

Re: [Bioc-devel] Resetting to previous commits

2019-08-14 Thread Mike Smith
Yes, the Bioconductor build system will only try to build the most recent version in the git repository. If it never managed to successfully build a particular version then that version should not appear anywhere on the Bioc site. For example biomaRt is now on release 2.40.3, but version 2.40.2 n

Re: [Bioc-devel] Resetting to previous commits

2019-08-14 Thread Erik Fasterius
Thank you for the prompt response! I will just add more versions on top of what I have already added. Would it be correct to assume that Bioconductor will try to build the most recent version available, even though it failed builds for previous versions? Regarding the change, it was indeed a br

Re: [Bioc-devel] Resetting to previous commits

2019-08-14 Thread Kasper Daniel Hansen
You cannot revert. By pushing those updates, you released a version into the wild. It is true that as long as it doesn't build on the build servers, it would have been hard to obtain for anyone, but it is still possible through git. You need to update the version. Best, Kasper On Wed, Aug 14, 201

Re: [Bioc-devel] Resetting to previous commits

2019-08-14 Thread Kasper Daniel Hansen
Also, it is not clear to me if this qualifies for a update to the release branch. Updates to release should be restricted to critical bug fixes (although if tidyr updates will break your package, that sounds like a critical bug fix to me) Note to others: this (again) emphasizes that we may need to