Re: [Bioc-devel] New argument 'use.names' in granges() function

2016-06-17 Thread Leonard Goldstein
Thanks Hervé. Leonard On Fri, Jun 17, 2016 at 2:11 AM, Hervé Pagès wrote: > Done in SGSeq 1.6.3 (release) and 1.7.4 (devel). > > Also done in SomaticSignatures 2.8.4 (release) and 2.9.4 (devel). > > I scanned the entire Rpacks folder and those are the only 2 packages > I found that contain call

Re: [Bioc-devel] New argument 'use.names' in granges() function

2016-06-17 Thread Hervé Pagès
Done in SGSeq 1.6.3 (release) and 1.7.4 (devel). Also done in SomaticSignatures 2.8.4 (release) and 2.9.4 (devel). I scanned the entire Rpacks folder and those are the only 2 packages I found that contain calls to granges() with 2 unnamed arguments. Sorry for the trouble. H. On 06/16/2016 11:

Re: [Bioc-devel] New argument 'use.names' in granges() function

2016-06-16 Thread Hervé Pagès
Hi Leonard, I really like having 'use.names' before 'use.mcols'. Sorry for breaking SGSeq, I'll fix it. FWIW I think it's good practice to always name this kind of arguments. Not the first argument 'x' or the first 2 arguments 'x' and 'y' of a unary or binary function, but the toggles that follo