>
> flowCore should not depend on ks anymore
Thanks Mike,
that's good news. Let me just second the opinion that getting rid of any
"windowing system" dependency in flowCore is a good choice. Last week, I
was trying to get a GenePattern module to work on a server at BROAD, and I
needed flowCore for
class, whereas dispatch is looking for
> > curv1Fitler,flowStats-class.
> >
> > Maybe a solution is in the fact that 'filter' actually seems to
> work --
> >
> > > selectMethod(filter, c(class(dat), class(c1f)))
> >
lter"
> >
> > I'm suspecting that the method here is specific to
> > curv1Filter,flowCore-class, whereas dispatch is looking for
> > curv1Fitler,flowStats-class.
> >
> > Maybe a solution is in the fact that 'filter' actually
filter' actually seems to work --
> selectMethod(filter, c(class(dat), class(c1f)))
...
Signatures:
x filter
target "flowFrame" "curv1Filter"
defined "flowFrame" "filter"
it finds the method for the base class shared by
curv1Filt
lass, so defining a common class curv1Filter_migration
and methods on that ?
Martin
Before I decide to remove the duplicated definitions from 'flowCore'
entirely (which is not desired), Does anyone know how to solve this issue?
Thanks,
Mike
On 04/16/2014 05:06 PM, Mike wrote:
Kevin&
ng using curv1Filter
fres <- filter(dat, c1f)
Error in match(x, table, nomatch = 0L) :
'match' requires vector arguments
Before I decide to remove the duplicated definitions from 'flowCore'
entirely (which is not desired), Does anyone know how to solve this issue?
Thank
Kevin's fix is already pushed to the latest bioc release and devel.
Thanks,
Mike
On 04/10/2014 11:44 PM, bioc-devel-requ...@r-project.org wrote:
> Subject:
> Re: [Bioc-devel] Dependency on windowing systems in the flowCore package
> From:
> Kieran O'Neill
> Date:
>
Thanks Kevin!
That would have been my proposed option 3 if I had realised it would be
that simple.
This will make my (and several other analysts I know's) lives a lot easier!
Cheers,
Kieran
On 10 April 2014 16:11, Kevin Ushey wrote:
> Hi Kieran,
>
> I've kickstarted the process by sending
Hi Kieran,
I've kickstarted the process by sending a pull request here:
https://github.com/RGLab/flowCore/pull/21
Thanks,
Kevin
On Thu, Apr 10, 2014 at 3:48 PM, Kasper Daniel Hansen <
kasperdanielhan...@gmail.com> wrote:
> My 2ct is that it is worthwhile to have a lean core package. It sounds
My 2ct is that it is worthwhile to have a lean core package. It sounds
like it would be trivial to separate gating into a new package, and -
provided functions are not renamed - would be trivial for downstream
packages to adapt to.
Especially in situations where competing groups work on the same
Hi Kieran, Dan,
I would suggest that you open an issue at
https://github.com/RGLab/flowCore/issues/new.
Perhaps the easiest solution is to copy featureSignif from feature into
flowCore (giving adequate citation and such, respecting licenses...). It
looks like the function doesn't depend too much
On 10 April 2014 14:26, Dan Tenenbaum wrote:
> Hi Kieran,
>
>
> - Original Message -
> > From: "Kieran O'Neill"
> > To: bioc-devel@r-project.org
> > Sent: Thursday, April 10, 2014 2:03:41 PM
> > Subject: [Bioc-devel] Dependency on windowing systems in the flowCore
> package
> >
> > In Bi
Hi Kieran,
- Original Message -
> From: "Kieran O'Neill"
> To: bioc-devel@r-project.org
> Sent: Thursday, April 10, 2014 2:03:41 PM
> Subject: [Bioc-devel] Dependency on windowing systems in the flowCore package
>
> In Bioconductor, the core infrastructure for loading and representing
>
13 matches
Mail list logo
