Re: [Bioc-devel] Compilation flags, CHECK errors and BiocNeighbors

2018-12-21 Thread Aaron Lun
Thanks Val. Looks like BiocNeighbors is all green again in the latest build, so that’s a relief. One down, two to go - Windows CHECK failures seem to be the tokay2’s idea of Christmas presents. -A > On 20 Dec 2018, at 19:52, Obenchain, Valerie > wrote: > > The problem is that during the nig

Re: [Bioc-devel] Compilation flags, CHECK errors and BiocNeighbors

2018-12-20 Thread Obenchain, Valerie
The problem is that during the nightly builds, one of the Bioconductor packages writes out a .R/Makevars.win in biocbuild's HOME during R CMD build. Yesterday I removed the .R/ directory before the builds started and, as expected, today's NodeInfo on tokay2 and packages using the C++11 show th

Re: [Bioc-devel] Compilation flags, CHECK errors and BiocNeighbors

2018-12-18 Thread Obenchain, Valerie
The devel build report hasn't posted yet but I took a look at the new compiler flag output Herve implemented. The results show tokay2 is indeed using CXX11FLAGS: -O3 -march=native -mtune=native This is inconsistent with what we have in the R/etc//Makeconf for both architectures on both tokay1

Re: [Bioc-devel] Compilation flags, CHECK errors and BiocNeighbors

2018-12-17 Thread Shian Su
From what I can see in scPipe, it looks to me like there’s difference in flags for tokay1 and tokay2 (release and development). http://bioconductor.org/checkResults/release/bioc-LATEST/scPipe/tokay1-buildbin.html -O2 -Wall -mtune=generic http://bioconductor.org/checkResults/devel/bioc-LATEST/scP

Re: [Bioc-devel] Compilation flags, CHECK errors and BiocNeighbors

2018-12-17 Thread Aaron Lun
Thanks Val. I don�t think it�s a BiocNeighbors thing, as it doesn�t try to customize the compilation flags or have its own Makevars. Moreover, the �-O3 -mtune=native -mtune=generic� flags seem to show up on all of my packages containing C++11 code. Some cursory checks of other packages suggest t

Re: [Bioc-devel] Compilation flags, CHECK errors and BiocNeighbors

2018-12-17 Thread Obenchain, Valerie
Hi Aaron, The only compilation flags that are different for tokay1 (release) and tokay2 (devel) are C++14 flags. BiocNeighbors is not using C++14 but C++11 so I think the changes we discussed previously actually don't apply to your case. All compilation flags we use are listed at the top of th

Re: [Bioc-devel] Compilation flags, CHECK errors and BiocNeighbors

2018-12-16 Thread Kasper Daniel Hansen
I would hope we do not distribute binaries compiled with -march=native That seems very wrong. On Sun, Dec 16, 2018 at 1:56 AM Aaron Lun < infinite.monkeys.with.keyboa...@gmail.com> wrote: > Sometime between 6-18 November, BiocNeighbors’ BioC-devel builds began > failing on Windows 64-bit, and