Re: [Bioc-devel] Reverting on the 'master' branch

2020-03-03 Thread Roel Janssen
Except that it's impossible to have version 1.99.0 installed because the build fails. I will try to work on the bugs that I introduced to get the features in shape before the next Bioconductor release. Thanks all for your replies! Kind regards, Roel Janssen On Tue, 2020-03-03 at 15:42 +, M

Re: [Bioc-devel] Reverting on the 'master' branch

2020-03-03 Thread Martin Morgan
Once a version has been made 'public', it's not possible to go backward -- R will say 'hey, you've got version 1.99.0 installed, so that's more recent than 1.13.0, so I won't update it'. So you're stuck with the version going forward. Martin On 3/3/20, 10:14 AM, "Bioc-devel on behalf of Turaga

Re: [Bioc-devel] Reverting on the 'master' branch

2020-03-03 Thread Turaga, Nitesh
Hi Roel, I think at this point it makes sense to move forward. It is more trouble than it's worth to do "hard resets" and then edit version numbers manually. Or another thing you could do is, roll out some big changes before the next release ;) Best, Nitesh > On Mar 2, 2020, at 5:09 PM, R

Re: [Bioc-devel] Reverting on the 'master' branch

2020-03-02 Thread Roel Janssen
Dear Nitesh, Thanks for the quick replies. And sorry for mixing your first and last name up. :) Well, we'd like to reserve 2.0.0 of our package for a "big feature update". But after some local testing we found a few bugs we cannot easily resolve. I already pushed those changes to the Bioconduc

Re: [Bioc-devel] Reverting on the 'master' branch

2020-03-02 Thread Turaga, Nitesh
I suggest you go forward with the version numbering. 1.99.0 --> 1.99.1 At the next release your package will have 2.0.0. Take a look at the version numbering document http://bioconductor.org/developers/how-to/version-numbering/. Make the changes you need to and go to version number 1.99.1.

Re: [Bioc-devel] Reverting on the 'master' branch

2020-03-02 Thread Roel Janssen
Dear Turaga, How do you suggest I do the equivalent of reverting a commit? My package name is MutationalPatterns. Kind regards, Roel Janssen On Mon, 2020-03-02 at 17:40 +, Turaga, Nitesh wrote: > Hi Roel, > > You cannot revert on the Git Bioconductor repo. > > What is your package name?

Re: [Bioc-devel] Reverting on the 'master' branch

2020-03-02 Thread Turaga, Nitesh
Hi Roel, You cannot revert on the Git Bioconductor repo. What is your package name? > On Mar 2, 2020, at 10:51 AM, Roel Janssen wrote: > > Dear Bioconductor developers, > > I'd like to revert the changes I made on the development branch > ("master" in Git), but a pre-receive hook that checks

[Bioc-devel] Reverting on the 'master' branch

2020-03-02 Thread Roel Janssen
Dear Bioconductor developers, I'd like to revert the changes I made on the development branch ("master" in Git), but a pre-receive hook that checks version numbers prevents me from reverting the change: remote: Error: Illegal version bump from '1.99.0' to '1.13.0' The commit I am trying to rev