Re: [Bioc-devel] A handful of check to follow up on R CMD BiocCheck

2016-11-10 Thread Martin Morgan
On 11/10/2016 05:36 AM, Kevin RUE wrote: Hi Martin, Thanks for spending the time and effort to refactor and integrate my code into BiocCheck. I didn't intend to give you so much to think about ! For the record, I used the "checkFunctionLengths" method (now starting at line 829 of checks.R) as a

Re: [Bioc-devel] A handful of check to follow up on R CMD BiocCheck

2016-11-10 Thread Kevin RUE
Hi Martin, Thanks for spending the time and effort to refactor and integrate my code into BiocCheck. I didn't intend to give you so much to think about ! For the record, I used the "checkFunctionLengths" method (now starting at line 829 of checks.R) as a template to offer code somewhat homogenous

Re: [Bioc-devel] A handful of check to follow up on R CMD BiocCheck

2016-11-09 Thread Martin Morgan
On 11/03/2016 08:14 AM, Kevin RUE wrote: Apologies for the additional spam, for two reasons: * The diff files that I've previously sent had the base and modified versions swapped. This new one fixes that. * This new diff file (always relative to the code I cloned from Bioconductor-mi

Re: [Bioc-devel] A handful of check to follow up on R CMD BiocCheck

2016-11-03 Thread Kevin RUE
Apologies for the additional spam, for two reasons: - The diff files that I've previously sent had the base and modified versions swapped. This new one fixes that. - This new diff file (always relative to the code I cloned from Bioconductor-mirror) also fixes a bug whereby the updated

Re: [Bioc-devel] A handful of check to follow up on R CMD BiocCheck

2016-11-03 Thread Kevin RUE
Hi all, Please find attached the diff relative to the code that I cloned from Bioconductor-mirror yesterday (please ignore the previous diff file). Basically three new features: - As per previous email: display up to the first 6 lines that are over 80 characters long - *New*: display up

Re: [Bioc-devel] A handful of check to follow up on R CMD BiocCheck

2016-11-02 Thread Kevin RUE
Me again :) Please find attached the first patch to print the first 6 lines over 80 characters long. (I'll get to the tabulation offenders next). Note that all the offending lines are stored in the "df.length" data.frame. How about an option like "fullReport=c(FALSE, TRUE)" that print *all* the o

Re: [Bioc-devel] A handful of check to follow up on R CMD BiocCheck

2016-11-02 Thread Kevin RUE
Thanks for the feedback! I also tend to prefer *all* the lines being reported (or to be honest, that was really true when I had lots of them; a problem that I largely mitigated by fixing all of them once and subsequently paying more attention while developing). Printing the content of the offendi

Re: [Bioc-devel] A handful of check to follow up on R CMD BiocCheck

2016-11-02 Thread Kasper Daniel Hansen
I would prefer all line numbers reported, but on the other hand I am indifferent wrt. the content of the line, unless (say) TABs are marked up somehow. Kasper On Wed, Nov 2, 2016 at 3:17 PM, Martin Morgan wrote: > On 11/02/2016 02:49 PM, Kevin RUE wrote: > >> Dear all, >> >> Just thought I'd sh

Re: [Bioc-devel] A handful of check to follow up on R CMD BiocCheck

2016-11-02 Thread Martin Morgan
On 11/02/2016 02:49 PM, Kevin RUE wrote: Dear all, Just thought I'd share a handful of scripts that I wrote to follow up on certain NOTE messages thrown by R CMD BiocCheck. https://github.com/kevinrue/BiocCheckTools They're very simple, but I occasionally find them quite convenient. Apologies

Re: [Bioc-devel] A handful of check to follow up on R CMD BiocCheck

2016-11-02 Thread Kasper Daniel Hansen
seems pretty useful. Would be improved by a single master file which runs everything and gives a report. On Wed, Nov 2, 2016 at 2:49 PM, Kevin RUE wrote: > Dear all, > > Just thought I'd share a handful of scripts that I wrote to follow up on > certain NOTE messages thrown by R CMD BiocCheck. >

[Bioc-devel] A handful of check to follow up on R CMD BiocCheck

2016-11-02 Thread Kevin RUE
Dear all, Just thought I'd share a handful of scripts that I wrote to follow up on certain NOTE messages thrown by R CMD BiocCheck. https://github.com/kevinrue/BiocCheckTools They're very simple, but I occasionally find them quite convenient. Apologies if something similar already exists somewhe