Re: [Bioc-devel] readVcf problems in package check

2019-05-01 Thread Pages, Herve
Hi Lindsay, Is this issue specific to the Windows CRAN checks? This Windows-specific error was also affecting several Bioconductor packages until recently but has been addressed in the latest version of Rhtslib (v 1.15.6). What version of Rhtslib are they using for the CRAN checks? They need t

Re: [Bioc-devel] 'MoonlightR' Bioconductor package ERROR

2019-05-01 Thread Antonio Colaprico
Dear Kayla, thank you for writing us about the MoonlightR package. I am one of the maintainer of the package, I got this mail from Catharina. Please as I changed University can you update my contact mail to axc1...@med.miami.edu ? I am currently out of the office for a conference, I will come b

[Bioc-devel] readVcf problems in package check

2019-05-01 Thread Clark, Lindsay V
I'm the maintainer of polyRAD, which is hosted on CRAN but dependent on several Bioconductor packages including VariantAnnotation. I'm not sure if my problem is on CRAN's end or Bioconductor's end, but in any event I have not gotten a response from CRAN yet so I thought I would ask here. I am

Re: [Bioc-devel] When to use generics?

2019-05-01 Thread Pages, Herve
Hi Boris, AFAICT the ::() syntax also works well with generics. Note that people sometimes specify the that exports some specific method for the generic when they should actually specify the where the generic is defined. One thing about the "regular function with if (is()) statements" vs ge

Re: [Bioc-devel] When to use generics?

2019-05-01 Thread Michael Lawrence via Bioc-devel
They're symbols in the namespace, so namespace qualification is possible. On Wed, May 1, 2019 at 10:15 AM Boris Steipe wrote: > I am more and more emphasizing ::() syntax in my > teaching, to avoid the issues that library() have wrt. order of > loading, and clarity of code. It's my understanding

Re: [Bioc-devel] When to use generics?

2019-05-01 Thread Boris Steipe
I am more and more emphasizing ::() syntax in my teaching, to avoid the issues that library() have wrt. order of loading, and clarity of code. It's my understanding that that's a general trend. Now, do correct me if I'm wrong but IIRC, that doesn't work well with generics because they don't ge

Re: [Bioc-devel] When to use generics?

2019-05-01 Thread Michael Lawrence via Bioc-devel
This is good advice. The purpose of the software also matters. The main advantage of a generic is extensibility. If extensibility is important, generics are appropriate, even if there is no immediate need for polymorphism. Bioconductor emphasizes extensibility, and thus generics, but it's not the o

Re: [Bioc-devel] When to use generics?

2019-05-01 Thread Kasper Daniel Hansen
This is a common situation. Most packages might have a need for something that looks like a generic, but it really only has a usage inside your own package(s). In many ways, the pseudo-generic you define using if() statements is often easier to work with, debugging wise and code-reading wise. Howe

[Bioc-devel] Last Day to Commit changes before release

2019-05-01 Thread Shepherd, Lori
Today is the last day to commit changes to the master (devel) branch for release 3.9 before we branch the official release. Tomorrow morning the branch will be frozen for a period of time and we will branch the new RELEASE_3_9 in git. The master (devel) branch will then be active for Bioc 3.1

Re: [Bioc-devel] check error in SeqVarTools

2019-05-01 Thread Shepherd, Lori
Since this changes does not affect the runnable code and only the test you can push whenever you like. Lori Shepherd Bioconductor Core Team Roswell Park Cancer Institute Department of Biostatistics & Bioinformatics Elm & Carlton Streets Buffalo, New York 14263