Re: [Bioc-devel] [Untrusted Server]Re: Rprintf in a multi-threaded environment

2019-01-30 Thread Yang Liao
I have just tried to pipe all the messages to the main thread – the new strategy is much easier to implement than I thought. The new code works well. Indeed, as long as the Rprintf function is only called by the main thread, it doesn’t matter how many worker threads are created. From: Shian Su

Re: [Bioc-devel] SetMethod to dispatch on class in unattached package

2019-01-30 Thread Michael Lawrence via Bioc-devel
Hopefully it could be implemented with minimal bloat, but I get your point. The intent is to clarify the source of the class, since it would not otherwise be imported. I think this is a fairly common case that is worth solving if it doesn't add too much complexity. On Wed, Jan 30, 2019 at 2:31 PM

Re: [Bioc-devel] SetMethod to dispatch on class in unattached package

2019-01-30 Thread Pages, Herve
Hi Michael, So IIUC this upfront class registration wouldn't do much beside making the "no definition for class 'seurat'" message issued by setMethod disappear. Maybe that's not enough to justify adding more bloat to the methods package? My 2 cents, H. On 1/30/19 13:35, Michael Lawrence via

Re: [Bioc-devel] SetMethod to dispatch on class in unattached package

2019-01-30 Thread Michael Lawrence via Bioc-devel
Unrelated to the specific question, a generic function introduces more vocabulary into the ecosystem. Since SingleCellExperiment defines the standard interface, why not make a new method on logcounts()? Back on topic, what if the methods package were to support forward class declarations? For exam

Re: [Bioc-devel] SetMethod to dispatch on class in unattached package

2019-01-30 Thread Brendan Innes
Thanks Martin! The fun strategy (zzz.R .onLoad setHook trick) worked well, except for setting this particular method: setMethod(scClustViz::getDR,"SingleCellExperiment",function(x,DRtype) { if (any(grepl(DRtype,SingleCellExperiment::reducedDimNames(x),ignore.case=T))) {

Re: [Bioc-devel] error pushing changes

2019-01-30 Thread Turaga, Nitesh
Hi Marta, I have fixed your repository in the Bioconductor repo. g...@git.bioconductor.org:packages/hipathia.git Please follow this document exactly as is, to sync your GitHub repository (http://bioconductor.org/developers/how-to/git/sync-existing-repositories/). If you are having issues with

Re: [Bioc-devel] SetMethod to dispatch on class in unattached package

2019-01-30 Thread Martin Morgan
A simple approach is to suppress the message (I think this is pragmatic, rather than dumb __) about unknown class (along with DESCRIPTION Suggests: Seurat) setGeneric("getGE", function(x) standardGeneric("getGE")) suppressMessages({ setMethod("getGE", "seurat", function(x) Seurat::GetAssayDa

Re: [Bioc-devel] error pushing changes

2019-01-30 Thread Marta Hidalgo
Hi Nitesh, Thank you for your quick answer and sorry for the trouble. Yes please, I think I'll need some help to fix this. Can you give me some instructions? Thank you again! Marta Marta Hidalgo De: Nitesh Turaga Enviado: mi